src/mips/macro-assembler-mips.cc - Issue 14429003: Refactor ExternalReference::isolate_address() to not rely on Isolate::Current().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips/macro-assembler-mips.cc

Issue 14429003: Refactor ExternalReference::isolate_address() to not rely on Isolate::Current(). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed comments Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/mips/macro-assembler-mips.cc

diff --git a/src/mips/macro-assembler-mips.cc b/src/mips/macro-assembler-mips.cc

index 6f9891469e38f24f291146e0a0695b595e180400..f18da1c90b46198109debd97aa1e0519246ce414 100644

--- a/src/mips/macro-assembler-mips.cc

+++ b/src/mips/macro-assembler-mips.cc

@@ -3996,7 +3996,7 @@ void MacroAssembler::CallApiFunctionAndReturn(ExternalReference function,

mov(s0, v0);

mov(a0, v0);

PrepareCallCFunction(1, s1);

- li(a0, Operand(ExternalReference::isolate_address()));

+ li(a0, Operand(ExternalReference::isolate_address(isolate())));

CallCFunction(ExternalReference::delete_handle_scope_extensions(isolate()),

1);

mov(v0, s0);

« no previous file with comments | « src/mips/deoptimizer-mips.cc ('k') | src/mips/regexp-macro-assembler-mips.h » ('j') | no next file with comments »