src/ia32/macro-assembler-ia32.cc - Issue 14429003: Refactor ExternalReference::isolate_address() to not rely on Isolate::Current().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/macro-assembler-ia32.cc

Issue 14429003: Refactor ExternalReference::isolate_address() to not rely on Isolate::Current(). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: addressed comments Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/macro-assembler-ia32.cc

diff --git a/src/ia32/macro-assembler-ia32.cc b/src/ia32/macro-assembler-ia32.cc

index 0eda69c97c4b39e744c0e65ff42f3baa00e8d32f..bad052c55e1e9e283d969684614cf65d976291d1 100644

--- a/src/ia32/macro-assembler-ia32.cc

+++ b/src/ia32/macro-assembler-ia32.cc

@@ -2086,7 +2086,8 @@ void MacroAssembler::CallApiFunctionAndReturn(Address function_address,

bind(&delete_allocated_handles);

mov(Operand::StaticVariable(limit_address), edi);

mov(edi, eax);

- mov(Operand(esp, 0), Immediate(ExternalReference::isolate_address()));

+ mov(Operand(esp, 0),

+ Immediate(ExternalReference::isolate_address(isolate())));

mov(eax, Immediate(delete_extensions));

call(eax);

mov(eax, edi);

« no previous file with comments | « src/ia32/deoptimizer-ia32.cc ('k') | src/ia32/regexp-macro-assembler-ia32.h » ('j') | no next file with comments »