Issue 14428004: dbus: Add FakeShillManagerClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14428004: dbus: Add FakeShillManagerClient (Closed)

Created:
7 years, 8 months ago by Haruki Sato

Modified:
7 years, 8 months ago

Reviewers:
satorux1

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

dbus: Add FakeShillManagerClient The fake class does nothing for now. We can implement fake behaviors when necessary. BUG=234463 TEST=trybots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196366

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+217 lines, -2 lines)			Patch
M	chromeos/chromeos.gyp	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A	chromeos/dbus/fake_shill_manager_client.h	View	1 2	1 chunk	+89 lines, -0 lines	0 comments	Download
A	chromeos/dbus/fake_shill_manager_client.cc	View		1 chunk	+117 lines, -0 lines	0 comments	Download
M	chromeos/dbus/mock_dbus_thread_manager_without_gmock.h	View		3 chunks	+6 lines, -0 lines	0 comments	Download
M	chromeos/dbus/mock_dbus_thread_manager_without_gmock.cc	View		3 chunks	+3 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

satorux1

lgtm, but please mention that all functions are empty as of now, in the patch ...

7 years, 8 months ago (2013-04-25 05:03:30 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haruki@chromium.org/14428004/8001

7 years, 8 months ago (2013-04-25 06:22:47 UTC) #3

Message was sent while issue was closed.

Change committed as 196366