Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14427002: Move InputMethodManager from c/b/chromeos to chromeos (Closed)

Created:
7 years, 8 months ago by Seigo Nonaka
Modified:
7 years, 8 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, sadrul, nkostylev+watch_chromium.org, derat+watch_chromium.org, Aaron Boodman, tfarina, ben+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Move InputMethodManager from c/b/chromeos to chromeos Moving only interface is easy and quite helpful for adding tests. Let me move this first. BUG=164375 TEST=try bots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196662

Patch Set 1 #

Patch Set 2 : Removing old header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -199 lines) Patch
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/input_method_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/input_method_apitest_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/input_method_event_router.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/browser_state_monitor.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine_ibus.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine_ibus_browserttests.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/chromeos/input_method/input_method_manager.h View 1 1 chunk +0 lines, -167 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_persistence.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/language_switch_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_display_host_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_manager_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/webui_login_display.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/preferences.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system_key_event_listener.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/xinput_hierarchy_changed_event_listener.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/event_rewriter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/ime_controller_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
A + chromeos/ime/input_method_manager.h View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Seigo Nonaka
7 years, 8 months ago (2013-04-23 13:25:30 UTC) #1
Seigo Nonaka
ping? just in case.
7 years, 8 months ago (2013-04-24 12:43:08 UTC) #2
satorux1
zork is back!
7 years, 8 months ago (2013-04-25 05:10:37 UTC) #3
Zachary Kuznia
It doesn't look like you removed the file from it's original location yet?
7 years, 8 months ago (2013-04-25 05:31:55 UTC) #4
Seigo Nonaka
Nice catch! I forgot removing it. Uploaded latest patchset, please take an another look? Thank ...
7 years, 8 months ago (2013-04-25 05:53:29 UTC) #5
Zachary Kuznia
lgtm
7 years, 8 months ago (2013-04-25 07:31:13 UTC) #6
Seigo Nonaka
Zach, thank you for your review. Satoru, could take an owner review as well for ...
7 years, 8 months ago (2013-04-25 07:37:42 UTC) #7
Ben Goodger (Google)
cbui lgtm
7 years, 8 months ago (2013-04-25 17:15:41 UTC) #8
Seigo Nonaka
Ben, Thank you for your review! Satoru, could you take an owner review? Some files ...
7 years, 8 months ago (2013-04-26 04:47:30 UTC) #9
satorux1
*/chromeos/* LGTM
7 years, 8 months ago (2013-04-26 04:49:48 UTC) #10
Seigo Nonaka
Satoru, Thank you for your review!
7 years, 8 months ago (2013-04-26 04:52:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/14427002/15002
7 years, 8 months ago (2013-04-26 04:52:17 UTC) #12
commit-bot: I haz the power
7 years, 8 months ago (2013-04-26 07:52:43 UTC) #13
Message was sent while issue was closed. 
Change committed as 196662

Powered by Google App Engine
This is Rietveld 408576698