Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 14413015: Exclude flaky PanelLayoutManagerTest.PanelAlignmentSecondDisplay test (Closed)

Created:
7 years, 8 months ago by oshima
Modified:
7 years, 8 months ago
Reviewers:
flackr
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Exclude flaky PanelLayoutManagerTest.PanelAlignmentSecondDisplay test TBR=flackr@chromium.org BUG=234854 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196101

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/valgrind/gtest_exclude/ash_unittests.gtest.txt View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/14413015/1
7 years, 8 months ago (2013-04-24 01:00:33 UTC) #1
commit-bot: I haz the power
Change committed as 196101
7 years, 8 months ago (2013-04-24 09:16:11 UTC) #2
flackr
lgtm. The failure is odd, it looks like the icon is 2px larger than the ...
7 years, 8 months ago (2013-04-24 12:46:49 UTC) #3
oshima
7 years, 8 months ago (2013-04-24 14:52:13 UTC) #4
could it be window being 2px smaller? (due to animation for example)


On Wed, Apr 24, 2013 at 5:46 AM, <flackr@chromium.org> wrote:

> lgtm. The failure is odd, it looks like the icon is 2px larger than the
> window
> but otherwise looks to be working correctly. I wonder why that would only
> be the
> case some of the time.
>
>
https://chromiumcodereview.**appspot.com/14413015/<https://chromiumcodereview...
>

Powered by Google App Engine
This is Rietveld 408576698