Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 1441013004: [Contextual Search] Add currently-private histograms. (Closed)

Created:
5 years, 1 month ago by Donn Denman
Modified:
5 years, 1 month ago
Reviewers:
Theresa, rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Contextual Search] Add currently-private histograms. We have a large set of histograms that were set up private before our feature launched, that should now be public. This adds those existing histograms. Removing the private ones will be done soon in the private repository. BUG=545055 Committed: https://crrev.com/db274ce9997f6b23b40f57b69a62d7fddb58474f Cr-Commit-Position: refs/heads/master@{#361229}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+506 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 7 chunks +506 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Donn Denman
Theresa, Please take a quick look at this change. I simply copied all the Contextual ...
5 years, 1 month ago (2015-11-12 23:23:06 UTC) #2
Theresa
lgtm
5 years, 1 month ago (2015-11-12 23:25:47 UTC) #3
Donn Denman
rkaplow@chromium.org: PTAL. This should just be a straight copy of the private histograms and enums ...
5 years, 1 month ago (2015-11-12 23:32:17 UTC) #5
rkaplow
lgtm
5 years, 1 month ago (2015-11-13 16:09:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1441013004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1441013004/20001
5 years, 1 month ago (2015-11-23 22:55:13 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-24 00:47:23 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-24 00:48:13 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/db274ce9997f6b23b40f57b69a62d7fddb58474f
Cr-Commit-Position: refs/heads/master@{#361229}

Powered by Google App Engine
This is Rietveld 408576698