chrome/test/data/extensions/api_test/service_worker/push_messaging/page.html - Issue 1440873004: Extension SW - add basic push messaging tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/api_test/service_worker/push_messaging/page.html

Issue 1440873004: Extension SW - add basic push messaging tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: forgot ot add web_manifest Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!-- Note that PushMessagingDispatcher::DoSubscribe() only looks at the web

	2 manifest, so we list the manifest here.

	3 However, this also means we cannot use PushMessaging from a service
	Devlin 2015/11/18 23:42:06 Hmm... not strictly true, right, as long as the ba Hmm... not strictly true, right, as long as the background page had an associated html page (and not a generated_background_page)? lazyboy 2015/11/19 02:40:28 That's right, updated the comment. Show quoted text On 2015/11/18 23:42:06, Devlin wrote: > Hmm... not strictly true, right, as long as the background page had an > associated html page (and not a generated_background_page)? That's right, updated the comment.
	4 worker of a background page.

	5 -->

	6 <link rel="manifest" href="web_manifest.json">

	7 <script src="page.js"></script>

OLD	NEW