rAc: remove bold section labels on linux_aura.

chrome/browser/ui/cocoa/autofill/autofill_section_container.mm

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/autofill/autofill_section_container.h"
 
 #include <algorithm>
 
 #include "base/mac/foundation_util.h"
 #include "base/strings/sys_string_conversions.h"
@@ skipping 81 matching lines @@
 
 // Updates input fields based on delegate status. If |shouldClobber| is YES,
 // will clobber existing data and reset fields to the initial values.
 - (void)updateAndClobber:(BOOL)shouldClobber;
 
 // Return YES if this is a section that contains CC info. (And, more
 // importantly, a potential CVV field)
 - (BOOL)isCreditCardSection;
 
 // Create properly styled label for section. Autoreleased.
-- (NSTextField*)makeDetailSectionLabel:(NSString*)labelText;
+- (NSTextField*)makeDetailSectionLabel:(const autofill::SectionLabel&)label;
 
 // Create a button offering input suggestions.
 - (MenuButton*)makeSuggestionButton;
 
 // Create a view with all inputs requested by |delegate_| and resets |input_|.
 - (void)makeInputControls;
 
 // Refresh all field icons based on |delegate_| status.
 - (void)updateFieldIcons;
 
@@ skipping 41 matching lines @@
 
   // Always request re-layout on state change.
   id delegate = [[view_ window] windowController];
   if ([delegate respondsToSelector:@selector(requestRelayout)])
     [delegate performSelector:@selector(requestRelayout)];
 }
 
 - (void)loadView {
   [self makeInputControls];
 
-  base::string16 labelText = delegate_->LabelForSection(section_);
-  label_.reset(
-      [[self makeDetailSectionLabel:base::SysUTF16ToNSString(labelText)]
-          retain]);
+  const autofill::SectionLabel label = delegate_->LabelForSection(section_);
+  label_.reset([[self makeDetailSectionLabel:label] retain]);
 
   suggestButton_.reset([[self makeSuggestionButton] retain]);
   suggestContainer_.reset([[AutofillSuggestionContainer alloc] init]);
 
   view_.reset([[AutofillSectionView alloc] initWithFrame:NSZeroRect]);
   [self setView:view_];
   [view_ setSubviews:
       @[label_, inputs_, [suggestContainer_ view], suggestButton_]];
   if (tooltipController_) {
     [view_ addSubview:[tooltipController_ view]
@@ skipping 293 matching lines @@
              fromControls:(NSArray*)controls {
   for (NSControl<AutofillInputField>* input in controls) {
     DCHECK([input isKindOfClass:[NSControl class]]);
     DCHECK([input conformsToProtocol:@protocol(AutofillInputField)]);
     outputs->insert(std::make_pair(
         [self fieldTypeForControl:input],
         base::SysNSStringToUTF16([input fieldValue])));
   }
 }
 
-- (NSTextField*)makeDetailSectionLabel:(NSString*)labelText {
-  base::scoped_nsobject<NSTextField> label([[NSTextField alloc] init]);
-  [label setFont:
-      [[NSFontManager sharedFontManager] convertFont:[label font]
-                                         toHaveTrait:NSBoldFontMask]];
-  [label setStringValue:labelText];
-  [label setEditable:NO];
-  [label setBordered:NO];
-  [label setDrawsBackground:NO];
-  [label sizeToFit];
-  return label.autorelease();
+- (NSTextField*)makeDetailSectionLabel:(const autofill::SectionLabel&)label {
+  base::scoped_nsobject<NSTextField> textfield([[NSTextField alloc] init]);
+  if (label.font & ui::ResourceBundle::BoldFont) {

[Nico, 2014/01/23 03:13:56]

bitmasks in an api are bad api

+    [textfield setFont:
+        [[NSFontManager sharedFontManager] convertFont:[textfield font]
+                                           toHaveTrait:NSBoldFontMask]];
+  }
+  [textfield setStringValue:base::SysUTF16ToNSString(label.text)];
+  [textfield setEditable:NO];
+  [textfield setBordered:NO];
+  [textfield setDrawsBackground:NO];
+  [textfield sizeToFit];
+  return textfield.autorelease();
 }
 
 - (void)updateAndClobber:(BOOL)shouldClobber {
   if (shouldClobber) {
     [self makeInputControls];
   } else {
     const autofill::DetailInputs& updatedInputs =
         delegate_->RequestedFieldsForSection(section_);
 
     for (autofill::DetailInputs::const_iterator iter = updatedInputs.begin();
@@ skipping 229 matching lines @@
 
 - (void)activateFieldForType:(autofill::ServerFieldType)type {
   NSControl<AutofillInputField>* field = [inputs_ viewWithTag:type];
   if (field) {
     [[field window] makeFirstResponder:field];
     [self fieldEditedOrActivated:field edited:NO];
   }
 }
 
 @end