Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1118)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkFilter.java

Issue 1440623004: [Enhanced Bookmark]Rewrite initialization logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added another class: EBUIState. All EB will be remaned to B this month. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkFilter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkFilter.java b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkFilter.java
index e9282988098181adc4dc4439e16a36ec3d97cbc9..861afb2eba5a44c25d485845a7d528a15a23edcf 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkFilter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkFilter.java
@@ -8,5 +8,16 @@ package org.chromium.chrome.browser.enhancedbookmarks;
* Possible filters for the enhanced bookmarks.
*/
enum EnhancedBookmarkFilter {
- OFFLINE_PAGES
+ OFFLINE_PAGES("OFFLINE_PAGES");
newt (away) 2015/12/02 16:21:12 Is it too late to change the value to something mo
Ian Wen 2015/12/03 02:33:23 I wouldn't change it without the offline page folk
+
+ /**
+ * An {@link EnhancedBookmarkFilter} can be persisted in URLs. To ensure the
+ * URLs are consistent, values should remain the same even after the enums
+ * are renamed.
+ */
+ public final String value;
+
+ private EnhancedBookmarkFilter(String value) {
+ this.value = value;
+ }
}

Powered by Google App Engine
This is Rietveld 408576698