Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 14404011: Reenable test_isolate_mode=check by default on OSX. (Closed)

Created:
7 years, 8 months ago by M-A Ruel
Modified:
7 years, 8 months ago
Reviewers:
csharp
CC:
chromium-reviews, Vadim Sh.
Visibility:
Public.

Description

Reenable test_isolate_mode=check by default on OSX. This is not necessary to default to noop anymore. Defaulting to check was disabled on OSX because a problem during archival with symlink path case. This was fixed inside swarm_client. R=csharp@chromium.org BUG=98637 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195613

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
M-A Ruel
7 years, 8 months ago (2013-04-22 15:09:17 UTC) #1
csharp
lgtm
7 years, 8 months ago (2013-04-22 15:11:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/14404011/1
7 years, 8 months ago (2013-04-22 15:14:45 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=105344
7 years, 8 months ago (2013-04-22 17:15:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/14404011/1
7 years, 8 months ago (2013-04-22 17:51:00 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-22 21:47:57 UTC) #6
Message was sent while issue was closed.
Change committed as 195613

Powered by Google App Engine
This is Rietveld 408576698