Issue 14404007: Fix crash on extension IME reloading on Linux Desktop with chromeos=1.

Issue 14404007: Fix crash on extension IME reloading on Linux Desktop with chromeos=1. (Closed)

Created:
7 years, 8 months ago by Seigo Nonaka

Modified:
7 years, 8 months ago

Reviewers:
satorux1

CC:
chromium-reviews, nkostylev+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix crash on extension IME reloading on Linux Desktop with chromeos=1. I found crash is happened when the extension IME reloads on chrome://extensions page. This crash does not happens on actual chromeos devices and also checked new implementation does not break existing behaviors. BUG=None TEST=Manually checked not crashing on extension reloading both chromeos device and linux desktop. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195880

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Addressing comments #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -24 lines)			Patch
M	chrome/browser/chromeos/input_method/input_method_engine_ibus.cc	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download
M	chromeos/dbus/ibus/ibus_engine_service.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chromeos/dbus/ibus/ibus_engine_service.cc	View		2 chunks	+6 lines, -5 lines	0 comments	Download
M	chromeos/dbus/ibus/ibus_engine_service_unittest.cc	View		13 chunks	+13 lines, -13 lines	0 comments	Download
M	chromeos/dbus/ibus/mock_ibus_engine_service.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chromeos/dbus/ibus/mock_ibus_engine_service.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

satorux1

lgtm with a nit https://codereview.chromium.org/14404007/diff/5002/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc File chrome/browser/chromeos/input_method/input_method_engine_ibus.cc (right): https://codereview.chromium.org/14404007/diff/5002/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc#newcode69 chrome/browser/chromeos/input_method/input_method_engine_ibus.cc:69: // InputMethodManager once ibus-daemon is ...

7 years, 8 months ago (2013-04-23 03:28:30 UTC) #2

Seigo Nonaka

Thank you for your review. Submitting. https://codereview.chromium.org/14404007/diff/5002/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc File chrome/browser/chromeos/input_method/input_method_engine_ibus.cc (right): https://codereview.chromium.org/14404007/diff/5002/chrome/browser/chromeos/input_method/input_method_engine_ibus.cc#newcode69 chrome/browser/chromeos/input_method/input_method_engine_ibus.cc:69: // InputMethodManager once ...

7 years, 8 months ago (2013-04-23 07:13:35 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/14404007/15001

7 years, 8 months ago (2013-04-23 07:13:49 UTC) #4

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 8 months ago (2013-04-23 07:16:06 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/14404007/15001

7 years, 8 months ago (2013-04-23 13:32:52 UTC) #6

Message was sent while issue was closed.

Change committed as 195880

Expand Messages | Collapse Messages