Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: src/x64/macro-assembler-x64.h

Issue 14403015: Disallow dereferencing deferred handles when generating optimized code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/lithium-x64.h ('k') | src/x64/macro-assembler-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 331 matching lines...) Expand 10 before | Expand all | Expand 10 after
342 342
343 // Invoke the JavaScript function in the given register. Changes the 343 // Invoke the JavaScript function in the given register. Changes the
344 // current context to the context in the function before invoking. 344 // current context to the context in the function before invoking.
345 void InvokeFunction(Register function, 345 void InvokeFunction(Register function,
346 const ParameterCount& actual, 346 const ParameterCount& actual,
347 InvokeFlag flag, 347 InvokeFlag flag,
348 const CallWrapper& call_wrapper, 348 const CallWrapper& call_wrapper,
349 CallKind call_kind); 349 CallKind call_kind);
350 350
351 void InvokeFunction(Handle<JSFunction> function, 351 void InvokeFunction(Handle<JSFunction> function,
352 const ParameterCount& expected,
352 const ParameterCount& actual, 353 const ParameterCount& actual,
353 InvokeFlag flag, 354 InvokeFlag flag,
354 const CallWrapper& call_wrapper, 355 const CallWrapper& call_wrapper,
355 CallKind call_kind); 356 CallKind call_kind);
356 357
357 // Invoke specified builtin JavaScript function. Adds an entry to 358 // Invoke specified builtin JavaScript function. Adds an entry to
358 // the unresolved list if the name does not resolve. 359 // the unresolved list if the name does not resolve.
359 void InvokeBuiltin(Builtins::JavaScript id, 360 void InvokeBuiltin(Builtins::JavaScript id,
360 InvokeFlag flag, 361 InvokeFlag flag,
361 const CallWrapper& call_wrapper = NullCallWrapper()); 362 const CallWrapper& call_wrapper = NullCallWrapper());
(...skipping 417 matching lines...) Expand 10 before | Expand all | Expand 10 after
779 void Cmp(Register dst, Smi* src); 780 void Cmp(Register dst, Smi* src);
780 void Cmp(const Operand& dst, Smi* src); 781 void Cmp(const Operand& dst, Smi* src);
781 void Push(Handle<Object> source); 782 void Push(Handle<Object> source);
782 783
783 // Load a heap object and handle the case of new-space objects by 784 // Load a heap object and handle the case of new-space objects by
784 // indirecting via a global cell. 785 // indirecting via a global cell.
785 void LoadHeapObject(Register result, Handle<HeapObject> object); 786 void LoadHeapObject(Register result, Handle<HeapObject> object);
786 void PushHeapObject(Handle<HeapObject> object); 787 void PushHeapObject(Handle<HeapObject> object);
787 788
788 void LoadObject(Register result, Handle<Object> object) { 789 void LoadObject(Register result, Handle<Object> object) {
790 ALLOW_HANDLE_DEREF(isolate(), "heap object check");
789 if (object->IsHeapObject()) { 791 if (object->IsHeapObject()) {
790 LoadHeapObject(result, Handle<HeapObject>::cast(object)); 792 LoadHeapObject(result, Handle<HeapObject>::cast(object));
791 } else { 793 } else {
792 Move(result, object); 794 Move(result, object);
793 } 795 }
794 } 796 }
795 797
796 // Load a global cell into a register. 798 // Load a global cell into a register.
797 void LoadGlobalCell(Register dst, Handle<JSGlobalPropertyCell> cell); 799 void LoadGlobalCell(Register dst, Handle<JSGlobalPropertyCell> cell);
798 800
(...skipping 711 matching lines...) Expand 10 before | Expand all | Expand 10 after
1510 masm->popfq(); \ 1512 masm->popfq(); \
1511 } \ 1513 } \
1512 masm-> 1514 masm->
1513 #else 1515 #else
1514 #define ACCESS_MASM(masm) masm-> 1516 #define ACCESS_MASM(masm) masm->
1515 #endif 1517 #endif
1516 1518
1517 } } // namespace v8::internal 1519 } } // namespace v8::internal
1518 1520
1519 #endif // V8_X64_MACRO_ASSEMBLER_X64_H_ 1521 #endif // V8_X64_MACRO_ASSEMBLER_X64_H_
OLDNEW
« no previous file with comments | « src/x64/lithium-x64.h ('k') | src/x64/macro-assembler-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698