Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: src/isolate.h

Issue 14403015: Disallow dereferencing deferred handles when generating optimized code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/stub-cache-ia32.cc ('k') | src/isolate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 973 matching lines...) Expand 10 before | Expand all | Expand 10 after
984 984
985 #ifdef DEBUG 985 #ifdef DEBUG
986 HistogramInfo* heap_histograms() { return heap_histograms_; } 986 HistogramInfo* heap_histograms() { return heap_histograms_; }
987 987
988 JSObject::SpillInformation* js_spill_information() { 988 JSObject::SpillInformation* js_spill_information() {
989 return &js_spill_information_; 989 return &js_spill_information_;
990 } 990 }
991 991
992 int* code_kind_statistics() { return code_kind_statistics_; } 992 int* code_kind_statistics() { return code_kind_statistics_; }
993 993
994 bool AllowHandleDereference(); 994 HandleDereferenceGuard::State HandleDereferenceGuardState();
995 995
996 void SetAllowHandleDereference(bool allow); 996 void SetHandleDereferenceGuardState(HandleDereferenceGuard::State state);
997 #endif 997 #endif
998 998
999 #if defined(V8_TARGET_ARCH_ARM) && !defined(__arm__) || \ 999 #if defined(V8_TARGET_ARCH_ARM) && !defined(__arm__) || \
1000 defined(V8_TARGET_ARCH_MIPS) && !defined(__mips__) 1000 defined(V8_TARGET_ARCH_MIPS) && !defined(__mips__)
1001 bool simulator_initialized() { return simulator_initialized_; } 1001 bool simulator_initialized() { return simulator_initialized_; }
1002 void set_simulator_initialized(bool initialized) { 1002 void set_simulator_initialized(bool initialized) {
1003 simulator_initialized_ = initialized; 1003 simulator_initialized_ = initialized;
1004 } 1004 }
1005 1005
1006 HashMap* simulator_i_cache() { return simulator_i_cache_; } 1006 HashMap* simulator_i_cache() { return simulator_i_cache_; }
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
1067 date_cache_ = date_cache; 1067 date_cache_ = date_cache;
1068 } 1068 }
1069 1069
1070 CodeStubInterfaceDescriptor* 1070 CodeStubInterfaceDescriptor*
1071 code_stub_interface_descriptor(int index); 1071 code_stub_interface_descriptor(int index);
1072 1072
1073 void IterateDeferredHandles(ObjectVisitor* visitor); 1073 void IterateDeferredHandles(ObjectVisitor* visitor);
1074 void LinkDeferredHandles(DeferredHandles* deferred_handles); 1074 void LinkDeferredHandles(DeferredHandles* deferred_handles);
1075 void UnlinkDeferredHandles(DeferredHandles* deferred_handles); 1075 void UnlinkDeferredHandles(DeferredHandles* deferred_handles);
1076 1076
1077 #ifdef DEBUG
1078 bool IsDeferredHandle(Object** location);
1079 #endif // DEBUG
1080
1077 OptimizingCompilerThread* optimizing_compiler_thread() { 1081 OptimizingCompilerThread* optimizing_compiler_thread() {
1078 return &optimizing_compiler_thread_; 1082 return &optimizing_compiler_thread_;
1079 } 1083 }
1080 1084
1081 // PreInits and returns a default isolate. Needed when a new thread tries 1085 // PreInits and returns a default isolate. Needed when a new thread tries
1082 // to create a Locker for the first time (the lock itself is in the isolate). 1086 // to create a Locker for the first time (the lock itself is in the isolate).
1083 // TODO(svenpanne) This method is on death row... 1087 // TODO(svenpanne) This method is on death row...
1084 static v8::Isolate* GetDefaultIsolateForLocking(); 1088 static v8::Isolate* GetDefaultIsolateForLocking();
1085 1089
1086 MarkingThread** marking_threads() { 1090 MarkingThread** marking_threads() {
(...skipping 198 matching lines...) Expand 10 before | Expand all | Expand 10 after
1285 HashMap* simulator_i_cache_; 1289 HashMap* simulator_i_cache_;
1286 Redirection* simulator_redirection_; 1290 Redirection* simulator_redirection_;
1287 #endif 1291 #endif
1288 1292
1289 #ifdef DEBUG 1293 #ifdef DEBUG
1290 // A static array of histogram info for each type. 1294 // A static array of histogram info for each type.
1291 HistogramInfo heap_histograms_[LAST_TYPE + 1]; 1295 HistogramInfo heap_histograms_[LAST_TYPE + 1];
1292 JSObject::SpillInformation js_spill_information_; 1296 JSObject::SpillInformation js_spill_information_;
1293 int code_kind_statistics_[Code::NUMBER_OF_KINDS]; 1297 int code_kind_statistics_[Code::NUMBER_OF_KINDS];
1294 1298
1295 bool allow_compiler_thread_handle_deref_; 1299 HandleDereferenceGuard::State compiler_thread_handle_deref_state_;
1296 bool allow_execution_thread_handle_deref_; 1300 HandleDereferenceGuard::State execution_thread_handle_deref_state_;
1297 #endif 1301 #endif
1298 1302
1299 #ifdef ENABLE_DEBUGGER_SUPPORT 1303 #ifdef ENABLE_DEBUGGER_SUPPORT
1300 Debugger* debugger_; 1304 Debugger* debugger_;
1301 Debug* debug_; 1305 Debug* debug_;
1302 #endif 1306 #endif
1303 CpuProfiler* cpu_profiler_; 1307 CpuProfiler* cpu_profiler_;
1304 HeapProfiler* heap_profiler_; 1308 HeapProfiler* heap_profiler_;
1305 1309
1306 #define GLOBAL_BACKING_STORE(type, name, initialvalue) \ 1310 #define GLOBAL_BACKING_STORE(type, name, initialvalue) \
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
1478 1482
1479 // Mark the native context with out of memory. 1483 // Mark the native context with out of memory.
1480 inline void Context::mark_out_of_memory() { 1484 inline void Context::mark_out_of_memory() {
1481 native_context()->set_out_of_memory(HEAP->true_value()); 1485 native_context()->set_out_of_memory(HEAP->true_value());
1482 } 1486 }
1483 1487
1484 1488
1485 } } // namespace v8::internal 1489 } } // namespace v8::internal
1486 1490
1487 #endif // V8_ISOLATE_H_ 1491 #endif // V8_ISOLATE_H_
OLDNEW
« no previous file with comments | « src/ia32/stub-cache-ia32.cc ('k') | src/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698