Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Side by Side Diff: src/ia32/macro-assembler-ia32.h

Issue 14403015: Disallow dereferencing deferred handles when generating optimized code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-ia32.h ('k') | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 253 matching lines...) Expand 10 before | Expand all | Expand 10 after
264 // Store the value in register/immediate src in the safepoint 264 // Store the value in register/immediate src in the safepoint
265 // register stack slot for register dst. 265 // register stack slot for register dst.
266 void StoreToSafepointRegisterSlot(Register dst, Register src); 266 void StoreToSafepointRegisterSlot(Register dst, Register src);
267 void StoreToSafepointRegisterSlot(Register dst, Immediate src); 267 void StoreToSafepointRegisterSlot(Register dst, Immediate src);
268 void LoadFromSafepointRegisterSlot(Register dst, Register src); 268 void LoadFromSafepointRegisterSlot(Register dst, Register src);
269 269
270 void LoadHeapObject(Register result, Handle<HeapObject> object); 270 void LoadHeapObject(Register result, Handle<HeapObject> object);
271 void PushHeapObject(Handle<HeapObject> object); 271 void PushHeapObject(Handle<HeapObject> object);
272 272
273 void LoadObject(Register result, Handle<Object> object) { 273 void LoadObject(Register result, Handle<Object> object) {
274 ALLOW_HANDLE_DEREF(isolate(), "heap object check");
274 if (object->IsHeapObject()) { 275 if (object->IsHeapObject()) {
275 LoadHeapObject(result, Handle<HeapObject>::cast(object)); 276 LoadHeapObject(result, Handle<HeapObject>::cast(object));
276 } else { 277 } else {
277 Set(result, Immediate(object)); 278 Set(result, Immediate(object));
278 } 279 }
279 } 280 }
280 281
281 // --------------------------------------------------------------------------- 282 // ---------------------------------------------------------------------------
282 // JavaScript invokes 283 // JavaScript invokes
283 284
(...skipping 29 matching lines...) Expand all
313 314
314 // Invoke the JavaScript function in the given register. Changes the 315 // Invoke the JavaScript function in the given register. Changes the
315 // current context to the context in the function before invoking. 316 // current context to the context in the function before invoking.
316 void InvokeFunction(Register function, 317 void InvokeFunction(Register function,
317 const ParameterCount& actual, 318 const ParameterCount& actual,
318 InvokeFlag flag, 319 InvokeFlag flag,
319 const CallWrapper& call_wrapper, 320 const CallWrapper& call_wrapper,
320 CallKind call_kind); 321 CallKind call_kind);
321 322
322 void InvokeFunction(Handle<JSFunction> function, 323 void InvokeFunction(Handle<JSFunction> function,
324 const ParameterCount& expected,
323 const ParameterCount& actual, 325 const ParameterCount& actual,
324 InvokeFlag flag, 326 InvokeFlag flag,
325 const CallWrapper& call_wrapper, 327 const CallWrapper& call_wrapper,
326 CallKind call_kind); 328 CallKind call_kind);
327 329
328 // Invoke specified builtin JavaScript function. Adds an entry to 330 // Invoke specified builtin JavaScript function. Adds an entry to
329 // the unresolved list if the name does not resolve. 331 // the unresolved list if the name does not resolve.
330 void InvokeBuiltin(Builtins::JavaScript id, 332 void InvokeBuiltin(Builtins::JavaScript id,
331 InvokeFlag flag, 333 InvokeFlag flag,
332 const CallWrapper& call_wrapper = NullCallWrapper()); 334 const CallWrapper& call_wrapper = NullCallWrapper());
(...skipping 692 matching lines...) Expand 10 before | Expand all | Expand 10 after
1025 } \ 1027 } \
1026 masm-> 1028 masm->
1027 #else 1029 #else
1028 #define ACCESS_MASM(masm) masm-> 1030 #define ACCESS_MASM(masm) masm->
1029 #endif 1031 #endif
1030 1032
1031 1033
1032 } } // namespace v8::internal 1034 } } // namespace v8::internal
1033 1035
1034 #endif // V8_IA32_MACRO_ASSEMBLER_IA32_H_ 1036 #endif // V8_IA32_MACRO_ASSEMBLER_IA32_H_
OLDNEW
« no previous file with comments | « src/ia32/lithium-ia32.h ('k') | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698