Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Side by Side Diff: src/factory.cc

Issue 14403015: Disallow dereferencing deferred handles when generating optimized code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/compiler.cc ('k') | src/handles.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 458 matching lines...) Expand 10 before | Expand all | Expand 10 after
469 isolate()->heap()->AllocateExternalArray(length, 469 isolate()->heap()->AllocateExternalArray(length,
470 array_type, 470 array_type,
471 external_pointer, 471 external_pointer,
472 pretenure), 472 pretenure),
473 ExternalArray); 473 ExternalArray);
474 } 474 }
475 475
476 476
477 Handle<JSGlobalPropertyCell> Factory::NewJSGlobalPropertyCell( 477 Handle<JSGlobalPropertyCell> Factory::NewJSGlobalPropertyCell(
478 Handle<Object> value) { 478 Handle<Object> value) {
479 ALLOW_HANDLE_DEREF(isolate(),
480 "converting a handle into a global property cell");
479 CALL_HEAP_FUNCTION( 481 CALL_HEAP_FUNCTION(
480 isolate(), 482 isolate(),
481 isolate()->heap()->AllocateJSGlobalPropertyCell(*value), 483 isolate()->heap()->AllocateJSGlobalPropertyCell(*value),
482 JSGlobalPropertyCell); 484 JSGlobalPropertyCell);
483 } 485 }
484 486
485 487
486 Handle<Map> Factory::NewMap(InstanceType type, 488 Handle<Map> Factory::NewMap(InstanceType type,
487 int instance_size, 489 int instance_size,
488 ElementsKind elements_kind) { 490 ElementsKind elements_kind) {
(...skipping 995 matching lines...) Expand 10 before | Expand all | Expand 10 after
1484 return Handle<Object>::null(); 1486 return Handle<Object>::null();
1485 } 1487 }
1486 1488
1487 1489
1488 Handle<Object> Factory::ToBoolean(bool value) { 1490 Handle<Object> Factory::ToBoolean(bool value) {
1489 return value ? true_value() : false_value(); 1491 return value ? true_value() : false_value();
1490 } 1492 }
1491 1493
1492 1494
1493 } } // namespace v8::internal 1495 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/compiler.cc ('k') | src/handles.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698