Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: src/arm/macro-assembler-arm.h

Issue 14403015: Disallow dereferencing deferred handles when generating optimized code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/arm/macro-assembler-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 Heap::RootListIndex index, 171 Heap::RootListIndex index,
172 Condition cond = al); 172 Condition cond = al);
173 // Store an object to the root table. 173 // Store an object to the root table.
174 void StoreRoot(Register source, 174 void StoreRoot(Register source,
175 Heap::RootListIndex index, 175 Heap::RootListIndex index,
176 Condition cond = al); 176 Condition cond = al);
177 177
178 void LoadHeapObject(Register dst, Handle<HeapObject> object); 178 void LoadHeapObject(Register dst, Handle<HeapObject> object);
179 179
180 void LoadObject(Register result, Handle<Object> object) { 180 void LoadObject(Register result, Handle<Object> object) {
181 ALLOW_HANDLE_DEREF(isolate(), "heap object check");
181 if (object->IsHeapObject()) { 182 if (object->IsHeapObject()) {
182 LoadHeapObject(result, Handle<HeapObject>::cast(object)); 183 LoadHeapObject(result, Handle<HeapObject>::cast(object));
183 } else { 184 } else {
184 Move(result, object); 185 Move(result, object);
185 } 186 }
186 } 187 }
187 188
188 // --------------------------------------------------------------------------- 189 // ---------------------------------------------------------------------------
189 // GC Support 190 // GC Support
190 191
(...skipping 375 matching lines...) Expand 10 before | Expand all | Expand 10 after
566 567
567 // Invoke the JavaScript function in the given register. Changes the 568 // Invoke the JavaScript function in the given register. Changes the
568 // current context to the context in the function before invoking. 569 // current context to the context in the function before invoking.
569 void InvokeFunction(Register function, 570 void InvokeFunction(Register function,
570 const ParameterCount& actual, 571 const ParameterCount& actual,
571 InvokeFlag flag, 572 InvokeFlag flag,
572 const CallWrapper& call_wrapper, 573 const CallWrapper& call_wrapper,
573 CallKind call_kind); 574 CallKind call_kind);
574 575
575 void InvokeFunction(Handle<JSFunction> function, 576 void InvokeFunction(Handle<JSFunction> function,
577 const ParameterCount& expected,
576 const ParameterCount& actual, 578 const ParameterCount& actual,
577 InvokeFlag flag, 579 InvokeFlag flag,
578 const CallWrapper& call_wrapper, 580 const CallWrapper& call_wrapper,
579 CallKind call_kind); 581 CallKind call_kind);
580 582
581 void IsObjectJSObjectType(Register heap_object, 583 void IsObjectJSObjectType(Register heap_object,
582 Register map, 584 Register map,
583 Register scratch, 585 Register scratch,
584 Label* fail); 586 Label* fail);
585 587
(...skipping 862 matching lines...) Expand 10 before | Expand all | Expand 10 after
1448 #define __FILE_LINE__ __FILE__ ":" CODE_COVERAGE_TOSTRING(__LINE__) 1450 #define __FILE_LINE__ __FILE__ ":" CODE_COVERAGE_TOSTRING(__LINE__)
1449 #define ACCESS_MASM(masm) masm->stop(__FILE_LINE__); masm-> 1451 #define ACCESS_MASM(masm) masm->stop(__FILE_LINE__); masm->
1450 #else 1452 #else
1451 #define ACCESS_MASM(masm) masm-> 1453 #define ACCESS_MASM(masm) masm->
1452 #endif 1454 #endif
1453 1455
1454 1456
1455 } } // namespace v8::internal 1457 } } // namespace v8::internal
1456 1458
1457 #endif // V8_ARM_MACRO_ASSEMBLER_ARM_H_ 1459 #endif // V8_ARM_MACRO_ASSEMBLER_ARM_H_
OLDNEW
« no previous file with comments | « src/arm/lithium-codegen-arm.cc ('k') | src/arm/macro-assembler-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698