Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14401007: Add missing unistd.h include after r8765. (Closed)

Created:
7 years, 8 months ago by Raphael Kubo da Costa (rakuco)
Modified:
7 years, 8 months ago
Reviewers:
jvanverth1, bsalomon, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add missing unistd.h include after r8765. TEST=Build with GCC 4.8.0 and glibc 2.17. Committed: http://code.google.com/p/skia/source/detail?r=8809

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/ports/SkFontHost_fontconfig.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Raphael Kubo da Costa (rakuco)
7 years, 8 months ago (2013-04-22 13:48:09 UTC) #1
reed1
8765 is meant to be a temporary experiment, but obviously I don't want to break ...
7 years, 8 months ago (2013-04-22 13:50:50 UTC) #2
Raphael Kubo da Costa (rakuco)
On 2013/04/22 13:50:50, reed1 wrote: > 1. what exactly is needed from unistd.h for this? ...
7 years, 8 months ago (2013-04-22 14:07:00 UTC) #3
reed1
lgtm
7 years, 8 months ago (2013-04-22 14:10:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/14401007/3001
7 years, 8 months ago (2013-04-22 14:13:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/14401007/3001
7 years, 8 months ago (2013-04-22 15:29:18 UTC) #6
commit-bot: I haz the power
7 years, 8 months ago (2013-04-22 19:34:44 UTC) #7
Message was sent while issue was closed. 
Change committed as 8809

Powered by Google App Engine
This is Rietveld 408576698