Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: tools/dom/templates/html/impl/impl_AudioContext.darttemplate

Issue 14400004: First try at removing ? from HTML. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Made positional arguments make more sense, Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/dom/templates/html/impl/impl_AudioContext.darttemplate
diff --git a/tools/dom/templates/html/impl/impl_AudioContext.darttemplate b/tools/dom/templates/html/impl/impl_AudioContext.darttemplate
index 1ef4069fa5e4d011dc663061865ca1317b1f26fb..8212a1614a877dfdac0f1f61505fac42f3bd9d50 100644
--- a/tools/dom/templates/html/impl/impl_AudioContext.darttemplate
+++ b/tools/dom/templates/html/impl/impl_AudioContext.darttemplate
@@ -22,12 +22,12 @@ $if DART2JS
[int numberOfInputChannels, int numberOfOutputChannels]) {
var function = JS('dynamic', '#.createScriptProcessor || '
'#.createJavaScriptNode', this, this);
- if (?numberOfOutputChannels) {
- return JS('ScriptProcessorNode', '#.call(#, #, #, #)', function, this,
- bufferSize, numberOfInputChannels, numberOfOutputChannels);
- } else if (?numberOfInputChannels) {
+ if (numberOfInputChannels != null) {
blois 2013/04/30 01:12:19 Ditto- why flip order here?
return JS('ScriptProcessorNode', '#.call(#, #, #)', function, this,
bufferSize, numberOfInputChannels);
+ } else if (numberOfOutputChannels != null) {
+ return JS('ScriptProcessorNode', '#.call(#, #, #, #)', function, this,
+ bufferSize, numberOfInputChannels, numberOfOutputChannels);
} else {
return JS('ScriptProcessorNode', '#.call(#, #)', function, this,
bufferSize);

Powered by Google App Engine
This is Rietveld 408576698