tools/dom/src/chrome/custom_dart/app_window.create.dart - Issue 14400004: First try at removing ? from HTML.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/src/chrome/custom_dart/app_window.create.dart

Issue 14400004: First try at removing ? from HTML. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Made positional arguments make more sense, Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/dom/src/chrome/custom_dart/app_window.create.dart

diff --git a/tools/dom/src/chrome/custom_dart/app_window.create.dart b/tools/dom/src/chrome/custom_dart/app_window.create.dart

index 41a4670209638c440cd5f339c1f80d69fecd61df..5b909274c93699e15c337b51106f14f8f2e8f353 100644

--- a/tools/dom/src/chrome/custom_dart/app_window.create.dart

+++ b/tools/dom/src/chrome/custom_dart/app_window.create.dart

@@ -7,7 +7,7 @@ void create(String url,

[AppWindowCreateWindowOptions options,

void callback(AppWindowAppWindow created_window)]) {

void __proxy_callback(created_window) {

- if (?callback)

+ if (callback != null)

callback(new AppWindowAppWindow._proxy(created_window));

}

JS('void', '#.create(#, #, #)', this._jsObject, url, convertArgument(options),