sdk/lib/html/dart2js/html_dart2js.dart - Issue 14400004: First try at removing ? from HTML.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Issue 14400004: First try at removing ? from HTML. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Made positional arguments make more sense, Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/html/dart2js/html_dart2js.dart

diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart

index d9fccaef4391b92c0def8ead4924c0b08c035af1..474fbf42d85f253ef5c1de759966c63021f2de84 100644

--- a/sdk/lib/html/dart2js/html_dart2js.dart

+++ b/sdk/lib/html/dart2js/html_dart2js.dart

@@ -17845,7 +17845,7 @@ class RtcPeerConnection extends EventTarget native "RTCPeerConnection" {

factory RtcPeerConnection(Map rtcIceServers, [Map mediaConstraints]) {

var constructorName = JS('RtcPeerConnection', 'window[#]',

'${Device.propertyPrefix}RTCPeerConnection');

- if (?mediaConstraints) {

+ if (mediaConstraints != null) {

return JS('RtcPeerConnection', 'new #(#,#)', constructorName,

convertDartToNative_SerializedScriptValue(rtcIceServers),

convertDartToNative_SerializedScriptValue(mediaConstraints));