Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: sdk/lib/web_audio/dart2js/web_audio_dart2js.dart

Issue 14400004: First try at removing ? from HTML. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Reverted stupid things. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/web_audio/dart2js/web_audio_dart2js.dart
diff --git a/sdk/lib/web_audio/dart2js/web_audio_dart2js.dart b/sdk/lib/web_audio/dart2js/web_audio_dart2js.dart
index 1dea2a141e9d0c498b3c4f7552e89988cf3b28c1..1dcc5990c77123e801864fbed306ed25848d5340 100644
--- a/sdk/lib/web_audio/dart2js/web_audio_dart2js.dart
+++ b/sdk/lib/web_audio/dart2js/web_audio_dart2js.dart
@@ -111,17 +111,17 @@ class AudioBufferSourceNode extends AudioSourceNode native "AudioBufferSourceNod
// instead of noteOn.
void start(num when, [num grainOffset, num grainDuration]) {
if (JS('bool', '!!#.start', this)) {
- if (?grainDuration) {
+ if (grainDuration != null) {
JS('void', '#.start(#, #, #)', this, when, grainOffset, grainDuration);
- } else if (?grainOffset) {
+ } else if (grainOffset != null) {
JS('void', '#.start(#, #)', this, when, grainOffset);
} else {
JS('void', '#.start(#)', this, when);
}
} else {
- if (?grainDuration) {
+ if (grainDuration != null) {
JS('void', '#.noteOn(#, #, #)', this, when, grainOffset, grainDuration);
- } else if (?grainOffset) {
+ } else if (grainOffset != null) {
JS('void', '#.noteOn(#, #)', this, when, grainOffset);
} else {
JS('void', '#.noteOn(#)', this, when);
@@ -300,10 +300,10 @@ class AudioContext extends EventTarget native "AudioContext" {
[int numberOfInputChannels, int numberOfOutputChannels]) {
var function = JS('dynamic', '#.createScriptProcessor || '
'#.createJavaScriptNode', this, this);
- if (?numberOfOutputChannels) {
+ if (numberOfOutputChannels != null) {
return JS('ScriptProcessorNode', '#.call(#, #, #, #)', function, this,
bufferSize, numberOfInputChannels, numberOfOutputChannels);
- } else if (?numberOfInputChannels) {
+ } else if (numberOfInputChannels != null) {
return JS('ScriptProcessorNode', '#.call(#, #, #)', function, this,
bufferSize, numberOfInputChannels);
} else {

Powered by Google App Engine
This is Rietveld 408576698