[Translate] Expose whether the user is within a navigation session as part of the infobar delegate

[Translate] Expose whether the user is within a navigation session as part of the infobar delegate

  - Add a new method to language state that returns if the user is navigating over translated links.
  - Use that method for the existing AutoTranslate() implementation.

BUG=234159
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196562

[MAD, 2013-04-25 15:25:36]

LGTM with two nit requests...

Thanks!

BYE
MAD

https://codereview.chromium.org/14392011/diff/4005/chrome/browser/tab_content...
File chrome/browser/tab_contents/language_state.cc (right):

https://codereview.chromium.org/14392011/diff/4005/chrome/browser/tab_content...
chrome/browser/tab_contents/language_state.cc:80: // - this page is not already
translated
missing a period ('.') at the end of the sentence...

And this doesn't look like a full sentence, can you rephrase it please?

https://codereview.chromium.org/14392011/diff/4005/chrome/browser/translate/t...
File chrome/browser/translate/translate_infobar_delegate.cc (right):

https://codereview.chromium.org/14392011/diff/4005/chrome/browser/translate/t...
chrome/browser/translate/translate_infobar_delegate.cc:117: 
Please remove extra empty line.

[Miguel Garcia, 2013-04-25 16:17:11]

Thanks!

https://codereview.chromium.org/14392011/diff/4005/chrome/browser/tab_content...
File chrome/browser/tab_contents/language_state.cc (right):

https://codereview.chromium.org/14392011/diff/4005/chrome/browser/tab_content...
chrome/browser/tab_contents/language_state.cc:80: // - this page is not already
translated
On 2013/04/25 15:25:36, MAD wrote:
> missing a period ('.') at the end of the sentence...
> 
> And this doesn't look like a full sentence, can you rephrase it please?

Done.

https://codereview.chromium.org/14392011/diff/4005/chrome/browser/translate/t...
File chrome/browser/translate/translate_infobar_delegate.cc (right):

https://codereview.chromium.org/14392011/diff/4005/chrome/browser/translate/t...
chrome/browser/translate/translate_infobar_delegate.cc:117: 
On 2013/04/25 15:25:36, MAD wrote:
> Please remove extra empty line.

Done.

[Miguel Garcia, 2013-04-25 16:18:05]

Adding Avi for chrome/browser/tab_contents/


On 2013/04/25 16:17:11, Miguel Garcia wrote:
> Thanks!
> 
>
https://codereview.chromium.org/14392011/diff/4005/chrome/browser/tab_content...
> File chrome/browser/tab_contents/language_state.cc (right):
> 
>
https://codereview.chromium.org/14392011/diff/4005/chrome/browser/tab_content...
> chrome/browser/tab_contents/language_state.cc:80: // - this page is not
already
> translated
> On 2013/04/25 15:25:36, MAD wrote:
> > missing a period ('.') at the end of the sentence...
> > 
> > And this doesn't look like a full sentence, can you rephrase it please?
> 
> Done.
> 
>
https://codereview.chromium.org/14392011/diff/4005/chrome/browser/translate/t...
> File chrome/browser/translate/translate_infobar_delegate.cc (right):
> 
>
https://codereview.chromium.org/14392011/diff/4005/chrome/browser/translate/t...
> chrome/browser/translate/translate_infobar_delegate.cc:117: 
> On 2013/04/25 15:25:36, MAD wrote:
> > Please remove extra empty line.
> 
> Done.

[Avi (use Gerrit), 2013-04-25 18:07:21]

lgtm

stampity stamp

[commit-bot: I haz the power, 2013-04-25 18:52:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miguelg@chromium.org/14392011/5013

[commit-bot: I haz the power, 2013-04-25 18:54:10]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_de...

[commit-bot: I haz the power, 2013-04-25 20:52:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miguelg@chromium.org/14392011/7007

[commit-bot: I haz the power, 2013-04-26 00:56:25]

Change committed as 196562