Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 14386024: Add debug shortcuts that toggles options to shows debug borders and fps counters (Closed)

Created:
7 years, 8 months ago by oshima
Modified:
7 years, 7 months ago
Reviewers:
James Cook, piman
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, ben+watch_chromium.org, Ian Vollick, jonathan.backer, mazda+watch_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org
Visibility:
Public.

Description

Add debug shortcuts that toggles options to shows debug borders and fps counters This is what's removed from https://codereview.chromium.org/14050009, plus dependency fix. Confirmed shared_library build works on win_aura. TBR=jamescook@chromium.org BUG=227375 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197029

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -9 lines) Patch
M ash/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ash/accelerators/accelerator_controller.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ash/accelerators/accelerator_table.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/accelerators/accelerator_table.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/ash.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ash/debug.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/debug.cc View 2 chunks +35 lines, -2 lines 0 comments Download
M ui/compositor/compositor.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/compositor/compositor.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
oshima
7 years, 8 months ago (2013-04-27 02:34:49 UTC) #1
piman
lgtm
7 years, 8 months ago (2013-04-27 04:44:43 UTC) #2
oshima
tbr'ing ash/ as this is basicalliy same as original CL
7 years, 8 months ago (2013-04-27 05:52:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/14386024/1
7 years, 8 months ago (2013-04-27 05:52:57 UTC) #4
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-27 06:06:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/14386024/1
7 years, 8 months ago (2013-04-27 07:19:28 UTC) #6
commit-bot: I haz the power
Retried try job too often on ios_rel_device for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_device&number=44786
7 years, 8 months ago (2013-04-27 08:19:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/14386024/1
7 years, 8 months ago (2013-04-27 10:26:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/14386024/1
7 years, 8 months ago (2013-04-27 10:26:48 UTC) #9
commit-bot: I haz the power
7 years, 7 months ago (2013-04-29 13:59:16 UTC) #10
Message was sent while issue was closed.
Change committed as 197029

Powered by Google App Engine
This is Rietveld 408576698