Issue 14386022: Fix uninitialized variable error in presubmit_support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14386022: Fix uninitialized variable error in presubmit_support (Closed)

Created:
7 years, 8 months ago by Isaac (away)

Modified:
7 years, 8 months ago

Reviewers:
cmp

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Fix uninitialized variable error in presubmit_support Remove 'out' variable reference. If subprocess.communicate() throws an exception, out cannot contain data. BUG=236073 TBR=cmp Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=196904

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	presubmit_support.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/14386022/3001

7 years, 8 months ago (2013-04-27 00:53:34 UTC) #2

commit-bot: I haz the power

Commit queue rejected this change because the description was changed between the time the change ...

7 years, 8 months ago (2013-04-27 00:55:17 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/14386022/3001

7 years, 8 months ago (2013-04-27 00:57:10 UTC) #4

Message was sent while issue was closed.

Change committed as 196904