Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14386016: dbus: Use base::MessageLoop. (Closed)

Created:
7 years, 8 months ago by xhwang
Modified:
7 years, 7 months ago
Reviewers:
keybuk, satorux1, satorux
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -30 lines) Patch
M dbus/bus.cc View 2 chunks +8 lines, -12 lines 0 comments Download
M dbus/bus_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M dbus/end_to_end_async_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M dbus/mock_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M dbus/object_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M dbus/property_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M dbus/signal_sender_verification_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M dbus/test_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M dbus/test_service.h View 1 chunk +1 line, -1 line 0 comments Download
M dbus/test_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
xhwang
PTAL! Format is corrected by clang-format-diff.py. If you feel any format change is bad please ...
7 years, 8 months ago (2013-04-26 23:29:33 UTC) #1
keybuk
+satorux
7 years, 8 months ago (2013-04-26 23:30:20 UTC) #2
xhwang
ping?
7 years, 7 months ago (2013-04-30 23:23:42 UTC) #3
satorux1
sorry for the belated response. LGTM. The format diff was surprisingly small. :)
7 years, 7 months ago (2013-05-01 00:59:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/14386016/1
7 years, 7 months ago (2013-05-01 01:01:07 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) cc_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=108938
7 years, 7 months ago (2013-05-01 02:47:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/14386016/1
7 years, 7 months ago (2013-05-01 05:21:25 UTC) #7
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=35292
7 years, 7 months ago (2013-05-01 07:09:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/14386016/1
7 years, 7 months ago (2013-05-01 08:07:41 UTC) #9
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=35372
7 years, 7 months ago (2013-05-01 10:16:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/14386016/1
7 years, 7 months ago (2013-05-01 14:37:57 UTC) #11
commit-bot: I haz the power
7 years, 7 months ago (2013-05-01 16:10:33 UTC) #12
Message was sent while issue was closed. 
Change committed as 197629

Powered by Google App Engine
This is Rietveld 408576698