Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 14386007: Remove some orphaned USE macros. (Closed)

Created:
7 years, 8 months ago by Julien - ping for review
Modified:
7 years, 8 months ago
Reviewers:
jamesr, abarth-chromium
CC:
blink-reviews, Nate Chapin, jeez, gavinp+loader_chromium.org, eseidel1
Visibility:
Public.

Description

Remove some orphaned USE macros. QXMLQUERY, APPKIT, SAFARI_THEME and IOSURFACE_CANVAS_BACKING_STORE were never defined. They also belong to other ports so can be safely removed. While touching this code, propagated the xmlDocPtr type into TransformSource from the XMLDocumentParser. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149223

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change updated after James' suggestion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -64 lines) Patch
M Source/core/dom/TransformSource.h View 1 2 chunks +4 lines, -9 lines 0 comments Download
M Source/core/dom/TransformSourceLibxslt.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/Editor.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/editing/Editor.cpp View 1 chunk +0 lines, -22 lines 0 comments Download
M Source/core/html/HTMLCanvasElement.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/loader/EmptyClients.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/page/EditorClient.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/page/Settings.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/platform/LocalizedStrings.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/xml/parser/XMLDocumentParser.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/parser/XMLDocumentParserLibxml2.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Julien - ping for review
7 years, 8 months ago (2013-04-26 20:54:37 UTC) #1
jamesr
lgtm https://codereview.chromium.org/14386007/diff/1/Source/core/dom/TransformSource.h File Source/core/dom/TransformSource.h (right): https://codereview.chromium.org/14386007/diff/1/Source/core/dom/TransformSource.h#newcode30 Source/core/dom/TransformSource.h:30: typedef void* PlatformTransformSource; there's almost certainly a better ...
7 years, 8 months ago (2013-04-26 21:00:41 UTC) #2
Julien - ping for review
https://codereview.chromium.org/14386007/diff/1/Source/core/dom/TransformSource.h File Source/core/dom/TransformSource.h (right): https://codereview.chromium.org/14386007/diff/1/Source/core/dom/TransformSource.h#newcode30 Source/core/dom/TransformSource.h:30: typedef void* PlatformTransformSource; On 2013/04/26 21:00:41, jamesr wrote: > ...
7 years, 8 months ago (2013-04-26 21:19:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/14386007/7001
7 years, 8 months ago (2013-04-26 21:22:52 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-26 21:56:23 UTC) #5
Message was sent while issue was closed.
Change committed as 149223

Powered by Google App Engine
This is Rietveld 408576698