Issue 14383024: ipc: Use base::MessageLoop.

Issue 14383024: ipc: Use base::MessageLoop. (Closed)

Created:
7 years, 7 months ago by xhwang

Modified:
7 years, 7 months ago

Reviewers:
agl

CC:
chromium-reviews, darin-cc_chromium.org, jam, sail+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ipc: Use base::MessageLoop. BUG=236029 R=agl@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197465

Patch Set 4 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+101 lines, -101 lines)			Patch
ipc/ipc_channel_factory.h	View		2 chunks	+3 lines, -2 lines	0 comments	Download
ipc/ipc_channel_factory.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
ipc/ipc_channel_posix.h	View		2 chunks	+5 lines, -4 lines	0 comments	Download
ipc/ipc_channel_posix.cc	View		3 chunks	+6 lines, -9 lines	0 comments	Download
ipc/ipc_channel_posix_unittest.cc	View		6 chunks	+8 lines, -11 lines	0 comments	Download
ipc/ipc_channel_unittest.cc	View		9 chunks	+9 lines, -9 lines	0 comments	Download
ipc/ipc_channel_win.h	View		2 chunks	+7 lines, -5 lines	0 comments	Download
ipc/ipc_channel_win.cc	View	1	5 chunks	+14 lines, -10 lines	0 comments	Download
ipc/ipc_fuzzing_tests.cc	View		4 chunks	+5 lines, -5 lines	0 comments	Download
ipc/ipc_logging.h	View		1 chunk	+1 line, -1 line	0 comments	Download
ipc/ipc_logging.cc	View		3 chunks	+5 lines, -4 lines	0 comments	Download
ipc/ipc_perftests.cc	View		5 chunks	+5 lines, -5 lines	0 comments	Download
ipc/ipc_send_fds_test.cc	View		4 chunks	+5 lines, -5 lines	0 comments	Download
ipc/ipc_sync_channel.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
ipc/ipc_sync_channel_unittest.cc	View	1 2	6 chunks	+9 lines, -9 lines	0 comments	Download
ipc/ipc_test_base.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
ipc/sync_socket_unittest.cc	View		4 chunks	+5 lines, -5 lines	0 comments	Download
ipc/unix_domain_socket_util_unittest.cc	View		4 chunks	+7 lines, -11 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

agl

lgtm https://codereview.chromium.org/14383024/diff/1/ipc/ipc_sync_channel_unittest.cc File ipc/ipc_sync_channel_unittest.cc (right): https://codereview.chromium.org/14383024/diff/1/ipc/ipc_sync_channel_unittest.cc#newcode79 ipc/ipc_sync_channel_unittest.cc:79: ->PostTask(FROM_HERE, base::Bind(&Worker::OnStart, this)); This specific change is just ...

7 years, 7 months ago (2013-04-30 17:38:48 UTC) #3

xhwang

https://codereview.chromium.org/14383024/diff/1/ipc/ipc_sync_channel_unittest.cc File ipc/ipc_sync_channel_unittest.cc (right): https://codereview.chromium.org/14383024/diff/1/ipc/ipc_sync_channel_unittest.cc#newcode79 ipc/ipc_sync_channel_unittest.cc:79: ->PostTask(FROM_HERE, base::Bind(&Worker::OnStart, this)); On 2013/04/30 17:38:49, agl wrote: > ...

7 years, 7 months ago (2013-04-30 17:46:54 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/14383024/20001

7 years, 7 months ago (2013-04-30 17:48:07 UTC) #5

Message was sent while issue was closed.

Change committed as 197465

Expand Messages | Collapse Messages