Break config_default into master_site_configs.

Break config_default into master_site_configs.

This CL takes data out of build/site_config/config_default and puts it in a
bunch of master-specific master_site_config.py files. This allows for greater
modularity and ease of development. We leave config_default containing just a
collection of shared base classes that master_site_configs can import and
inherit from.

This CL also contains minor edits to other files (the presubmit tests and a
couple factories) to accomodate this change.

TEST=masters_test, masters_cfg_test, and mastermap all pass and give sane
results both with and without a build_internal checkout.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=201052

[agable, 2013-04-27 02:49:28]

Wheeee.

[Isaac (away), 2013-04-29 01:27:57]

nice CL!  Some comments inline.

https://codereview.chromium.org/14383021/diff/1/masters/master.chromium.chrom...
File masters/master.chromium.chrome/master.cfg (right):

https://codereview.chromium.org/14383021/diff/1/masters/master.chromium.chrom...
masters/master.chromium.chrome/master.cfg:16: import config
This existing master_site_configs (like master.chromium.linux) extend from
Object instead of from a config base class.  But since the new ones extend from
config, do we need to refer to the config module directly rather than through
ActiveMaster object?

https://codereview.chromium.org/14383021/diff/1/masters/master.client.skia/ma...
File masters/master.client.skia/master_site_config.py (right):

https://codereview.chromium.org/14383021/diff/1/masters/master.client.skia/ma...
masters/master.client.skia/master_site_config.py:18: is_production_host =
socket.getfqdn() == production_host
can line 17/18 be simplified to:  is_production_host = False ?

Is it possible to put these lines in a base class?

[agable, 2013-04-29 17:40:20]

https://chromiumcodereview.appspot.com/14383021/diff/1/masters/master.chromiu...
File masters/master.chromium.chrome/master.cfg (right):

https://chromiumcodereview.appspot.com/14383021/diff/1/masters/master.chromiu...
masters/master.chromium.chrome/master.cfg:16: import config
The existing master_site_configs have been changed to inherit from config base
classes. That said, the master_site_configs do "from config import Master", so
we can't actually access config through them. In the spirit of having this
change be as minimally invasive as possible, I'd rather leave the 'import
configs' here, and fix those later when I move Archive and DatabaseSetup out of
config.

https://chromiumcodereview.appspot.com/14383021/diff/1/masters/master.client....
File masters/master.client.skia/master_site_config.py (right):

https://chromiumcodereview.appspot.com/14383021/diff/1/masters/master.client....
masters/master.client.skia/master_site_config.py:18: is_production_host =
socket.getfqdn() == production_host
On 2013/04/29 01:27:57, Isaac wrote:
> can line 17/18 be simplified to:  is_production_host = False ?
> 
> Is it possible to put these lines in a base class?

The Skia config is kinda a special case, since it is really just a stub (due to
skia maintaining their own buildbot master in the skia repo). But yes, I'll also
force is_production_host to False and add a comment explaining that it is a
stub.

[Isaac (away), 2013-04-30 04:14:05]

This is the output I get when I run masters_test:

http://pastebin.com/7UVE6beL

Does this CL need an accompanying private patch?

[agable, 2013-04-30 21:10:32]

Yep, and I just wrapped it up and mailed it out. PTAL at that one too.

[Isaac (away), 2013-05-04 06:31:48]

OK, I audited changes to the config objects using sed to rename
is_production_host lines to strings and then running:
http://pastebin.com/cuSVghu4


I'll do a second pass for code style.

https://chromiumcodereview.appspot.com/14383021/diff/20001/masters/master.chr...
File masters/master.chromium.chromiumos/master_site_config.py (right):

https://chromiumcodereview.appspot.com/14383021/diff/20001/masters/master.chr...
masters/master.chromium.chromiumos/master_site_config.py:15:
alternate_tree_closing_notification_recipients = (
both alternate keys are new

https://chromiumcodereview.appspot.com/14383021/diff/20001/masters/master.cli...
File masters/master.client.skia/master_site_config.py (right):

https://chromiumcodereview.appspot.com/14383021/diff/20001/masters/master.cli...
masters/master.client.skia/master_site_config.py:14: class Skia(Master.Master3):
lost its production host.  Looks fine.

https://chromiumcodereview.appspot.com/14383021/diff/20001/masters/master.try...
File masters/master.tryserver.chromium/master_site_config.py (right):

https://chromiumcodereview.appspot.com/14383021/diff/20001/masters/master.try...
masters/master.tryserver.chromium/master_site_config.py:9: class
TryServer(Master.Master4):
lost it's reply_to.  Use the email address currently in config_private.

https://chromiumcodereview.appspot.com/14383021/diff/20001/masters/master.try...
File masters/master.tryserver.webrtc/master_site_config.py (right):

https://chromiumcodereview.appspot.com/14383021/diff/20001/masters/master.try...
masters/master.tryserver.webrtc/master_site_config.py:9: class
WebRTCTryServer(Master.Master4):
This one lost its reply_to property, which used to come from config_private.

https://chromiumcodereview.appspot.com/14383021/diff/20001/site_config/config...
File site_config/config_default.py (left):

https://chromiumcodereview.appspot.com/14383021/diff/20001/site_config/config...
site_config/config_default.py:76: from_address = 'nobody@example.com'
noreply@google.com

https://chromiumcodereview.appspot.com/14383021/diff/20001/site_config/config...
site_config/config_default.py:78: reply_to = 'nobody@example.com'
noreply@google.com

https://chromiumcodereview.appspot.com/14383021/diff/20001/site_config/config...
File site_config/config_default.py (right):

https://chromiumcodereview.appspot.com/14383021/diff/20001/site_config/config...
site_config/config_default.py:66: is_production_host = False
This adds the is_production_host = False for masters which depend on Base.

Maybe we should have a default master_host, and change
Base is_production_host to a property which looks up master_host and checks if
equal to socket.getfqdn()

https://chromiumcodereview.appspot.com/14383021/diff/20001/site_config/config...
site_config/config_default.py:83: code_review_site =
'https://chromiumcodereview.appspot.com'
Not sure we want this in Base.

[agable, 2013-05-17 03:08:19]

Latest patchset addresses all of your comments, as well as resolves some other
minor diffs. This is ready to go.

[iannucci, 2013-05-17 04:28:09]

lgtm. Let's land this already. I'm assuming if something goes wrong a rollback
will fix it? Can this bork slaves?

[commit-bot: I haz the power, 2013-05-18 02:09:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/agable@chromium.org/14383021/32001

[commit-bot: I haz the power, 2013-05-18 02:10:25]

Presubmit check for 14383021-32001 failed and returned exit status 1.

INFO:root:Found 124 file(s).
INFO:PRESUBMIT:Running pylint on 378 files
Running presubmit commit checks ...
Running /b/commit-queue/workdir/tools/build/PRESUBMIT.py
Running test/masters_util_list_test.py
Running test/masters_test.py
Running test/tryserver_mail_test.py
Running test/masters_cfg_test.py
Running test/slaves_cfg_test.py
Running scripts/master/unittests/failures_notifier_test.py
Running scripts/master/unittests/gatekeeper_test.py
Running scripts/master/unittests/failures_history_test.py
Running scripts/master/unittests/chromium_utils_test.py
Running scripts/master/unittests/try_job_base_test.py
Running scripts/master/unittests/chromium_notifier_test.py
Running scripts/master/unittests/perf_count_notifier_test.py
Running scripts/master/unittests/gclient_source_test.py
Running scripts/master/unittests/process_log_test.py
Running scripts/master/unittests/chromium_commands_test.py
Running scripts/master/unittests/annotator_test.py
Running scripts/slave/unittests/get_swarm_results_test.py
Running scripts/slave/unittests/runisolatedtest_test.py
Running scripts/slave/unittests/extract_build_test.py
Running scripts/slave/unittests/recipe_util_test.py
Running scripts/slave/unittests/telemetry_test.py
Running scripts/slave/unittests/buildrunner_test.py
Running scripts/slave/unittests/runtest_annotator_test.py
Running scripts/slave/unittests/cleanup_old_files_test.py
Running scripts/slave/unittests/recipes_test.py
Running scripts/slave/unittests/results_dashboard_test.py
Running scripts/common/unittests/gtest_utils_test.py
Running scripts/common/unittests/annotator_test.py
Running scripts/tools/unittests/lkgr_finder_test.py

** Presubmit ERRORS **
test/masters_test.py failed
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.toolkit/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.v8/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.endure/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.memory/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.swarm/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.nacl.chrome/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.experimental/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.win/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.skia/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.tryserver.webrtc/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.sfntly/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.chromedriver/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.webrtc/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.dart.fyi/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.webrtc.fyi/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.pagespeed/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.libjingle/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.tryserver.chromium/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.dynamorio/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.syzygy/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.omaha/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.nacl.llvm/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.perf/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.memory.fyi/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.tryserver.nacl/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.webkit/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.nacl.sdk/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.linux/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.perf_av/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.gpu.fyi/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.chrome/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromiumos/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.nacl/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.nacl.toolchain/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.tryserver.libyuv/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.tryserver.chromium.linux/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.gatekeeper/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.lkgr/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.nacl.sdk.mono/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.flaky/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.webrtc/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.nacl.ragel/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.fyi/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.devtools/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.nacl.sdk.addin/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.drmemory/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.mac/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.libyuv/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.chromebot/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.gpu/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.dart/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.chromiumos/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.nacl.ports/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.git/master_site_config.py
No module named twisted.spread
Traceback (most recent call last):
  File "test/masters_test.py", line 270, in <module>
    sys.exit(main(sys.argv))
  File "test/masters_test.py", line 266, in main
    return real_main(all_masters)
  File "test/masters_test.py", line 143, in real_main
    master_class=getattr(master_classes, classname),
AttributeError: type object 'Master' has no attribute 'Chromium'


Presubmit checks took 35.7s to calculate.

[Isaac (away), 2013-05-19 23:37:28]

[lgtm]

Re breaking this CL into parts: I'm not convinced these need to be broken up; if
things go wrong, we can hopefully just revert.  I think these changes are
relatively safe.

[commit-bot: I haz the power, 2013-05-20 06:23:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/agable@chromium.org/14383021/51001

[commit-bot: I haz the power, 2013-05-20 06:24:22]

Presubmit check for 14383021-51001 failed and returned exit status 1.

INFO:root:Found 124 file(s).
INFO:PRESUBMIT:Running pylint on 378 files
Running presubmit commit checks ...
Running /b/commit-queue/workdir/tools/build/PRESUBMIT.py
Running test/masters_util_list_test.py
Running test/masters_test.py
Running test/tryserver_mail_test.py
Running test/masters_cfg_test.py
Running test/slaves_cfg_test.py
Running scripts/master/unittests/failures_notifier_test.py
Running scripts/master/unittests/gatekeeper_test.py
Running scripts/master/unittests/failures_history_test.py
Running scripts/master/unittests/chromium_utils_test.py
Running scripts/master/unittests/try_job_base_test.py
Running scripts/master/unittests/chromium_notifier_test.py
Running scripts/master/unittests/perf_count_notifier_test.py
Running scripts/master/unittests/gclient_source_test.py
Running scripts/master/unittests/process_log_test.py
Running scripts/master/unittests/chromium_commands_test.py
Running scripts/master/unittests/annotator_test.py
Running scripts/slave/unittests/get_swarm_results_test.py
Running scripts/slave/unittests/runisolatedtest_test.py
Running scripts/slave/unittests/extract_build_test.py
Running scripts/slave/unittests/recipe_util_test.py
Running scripts/slave/unittests/telemetry_test.py
Running scripts/slave/unittests/buildrunner_test.py
Running scripts/slave/unittests/runtest_annotator_test.py
Running scripts/slave/unittests/cleanup_old_files_test.py
Running scripts/slave/unittests/recipes_test.py
Running scripts/slave/unittests/results_dashboard_test.py
Running scripts/common/unittests/gtest_utils_test.py
Running scripts/common/unittests/annotator_test.py
Running scripts/tools/unittests/lkgr_finder_test.py

** Presubmit ERRORS **
test/masters_test.py failed
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.toolkit/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.v8/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.endure/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.memory/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.swarm/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.nacl.chrome/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.experimental/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.win/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.skia/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.tryserver.webrtc/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.sfntly/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.chromedriver/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.webrtc/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.dart.fyi/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.webrtc.fyi/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.pagespeed/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.libjingle/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.tryserver.chromium/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.dynamorio/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.syzygy/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.omaha/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.nacl.llvm/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.perf/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.memory.fyi/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.tryserver.nacl/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.webkit/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.nacl.sdk/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.linux/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.perf_av/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.gpu.fyi/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.chrome/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromiumos/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.nacl/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.nacl.toolchain/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.tryserver.libyuv/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.tryserver.chromium.linux/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.gatekeeper/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.lkgr/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.nacl.sdk.mono/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.flaky/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.webrtc/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.nacl.ragel/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.fyi/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.devtools/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.nacl.sdk.addin/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.drmemory/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.mac/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.libyuv/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.chromebot/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.gpu/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.dart/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.chromiumos/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.client.nacl.ports/master_site_config.py
No module named twisted.spread
WARNING: cannot exec
/b/commit-queue/workdir/tools/build/masters/master.chromium.git/master_site_config.py
No module named twisted.spread
Traceback (most recent call last):
  File "test/masters_test.py", line 264, in <module>
    sys.exit(main(sys.argv))
  File "test/masters_test.py", line 260, in main
    return real_main(all_masters)
  File "test/masters_test.py", line 143, in real_main
    master_class=getattr(master_classes, classname),
AttributeError: type object 'Master' has no attribute 'Chromium'


Presubmit checks took 35.4s to calculate.

[commit-bot: I haz the power, 2013-05-20 07:28:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/agable@chromium.org/14383021/56001

[commit-bot: I haz the power, 2013-05-20 07:31:14]

Change committed as 201052

[Nico, 2013-10-20 23:07:59]

This (re)created the masters/master.chromium.pyauto directory, which doesn't
seem to have anything interesting in it. Can that directory be deleted again?

[agable, 2013-10-21 16:30:02]

On 2013/10/20 23:07:59, Nico wrote:
> This (re)created the masters/master.chromium.pyauto directory, which doesn't
> seem to have anything interesting in it. Can that directory be deleted again?

https://codereview.chromium.org/32943002