Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 14373011: Update the path to iossim in the script run by Xcode to launch tests on simulator. (Closed)

Created:
7 years, 8 months ago by lliabraa
Modified:
7 years, 7 months ago
Reviewers:
TVL, Milan Broum
CC:
chromium-reviews
Visibility:
Public.

Description

Update the path to iossim in the script run by Xcode to launch tests on simulator. BUG=228157 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197491

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M testing/gtest_ios/run-unittest.sh View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 7 (0 generated)
lliabraa
7 years, 8 months ago (2013-04-25 09:24:46 UTC) #1
Milan Broum
lgtm
7 years, 8 months ago (2013-04-25 11:01:34 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 8 months ago (2013-04-25 12:01:30 UTC) #3
lliabraa
TVL - can you put a rubber stamp on this?
7 years, 8 months ago (2013-04-25 12:06:24 UTC) #4
TVL
lgtm https://chromiumcodereview.appspot.com/14373011/diff/1/testing/gtest_ios/run-unittest.sh File testing/gtest_ios/run-unittest.sh (right): https://chromiumcodereview.appspot.com/14373011/diff/1/testing/gtest_ios/run-unittest.sh#newcode22 testing/gtest_ios/run-unittest.sh:22: readonly SimExecutable="${BUILD_DIR}/ninja-iossim/${CONFIGURATION}/iossim" I guess there is no way ...
7 years, 8 months ago (2013-04-25 13:06:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lliabraa@chromium.org/14373011/1
7 years, 7 months ago (2013-04-30 16:16:14 UTC) #6
commit-bot: I haz the power
7 years, 7 months ago (2013-04-30 21:59:49 UTC) #7
Message was sent while issue was closed.
Change committed as 197491

Powered by Google App Engine
This is Rietveld 408576698