Source/core/html/HTMLDialogElement.h - Issue 14373010: Make abspos <dialog>'s containing block be the ICB.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLDialogElement.h

Issue 14373010: Make abspos <dialog>'s containing block be the ICB. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: review comments Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLDialogElement.h

diff --git a/Source/core/html/HTMLDialogElement.h b/Source/core/html/HTMLDialogElement.h

index 7cdb7394e02dc0e1c04cdc88a2ffeda0168d5af4..7dcbed6a7933f8a34fef5bc77d4a8598fd585c00 100644

--- a/Source/core/html/HTMLDialogElement.h

+++ b/Source/core/html/HTMLDialogElement.h

@@ -46,6 +46,7 @@ private:

virtual PassRefPtr<RenderStyle> customStyleForRenderer() OVERRIDE;

virtual bool isPresentationAttribute(const QualifiedName&) const OVERRIDE;

+ virtual bool shouldBeReparentedUnderRenderView(const RenderStyle*) const OVERRIDE;

void positionAndReattach();

bool m_topIsValid;