[MIPS] Add build support for MIPS in openssl.gyp

[MIPS] Add build support for MIPS in openssl.gyp

The gyp file missed support for MIPS arch. This caused a build break
when content shell was built for MIPS.

BUG=130022
TEST=build content shell for MIPS

[petarj, 2013-04-22 13:01:11]

PTAL.

[digit1, 2013-04-22 13:03:52]

lgtm - The Android build already supports MIPS.
I've added Ryan, Wan-Teh and Adam on CC.

[petarj, 2013-04-22 13:10:08]

On 2013/04/22 13:03:52, digit1 wrote:
> lgtm - The Android build already supports MIPS.
> I've added Ryan, Wan-Teh and Adam on CC.

Thanks for quick response.
Does CQ work for openssl repository?

[digit1, 2013-04-22 13:25:27]

Unfortunately not, you will have to perform a DEPS roll of OpenSSL in the main
Chromium repository to check that everything works well.

Note: when testing OpenSSL changes, I recommend the following:

  1/ Build the full "linux_redux" build, and run net_unittests here.
     E.g. (you will have to add "target_arch=mips"):

       GYP_DEFINES="linux_fpic=1 enable_touch_events=1 disable_nacl=1
linux_use_tcmalloc=0 linux_breakpad=0 remoting=0 configuration_policy=0
safe_browsing=0 use_openssl=1 component=static_library" build/gyp_chromium
-Goutput_dir=out_linux_redux
       ninja -C out_linux_redux/Debug
       out_linux_redux/Debug/net_unit_tests

   2/ Build the full Android builds for ARM and x86 as well, and,
      if possible run net_unittests with a connected device and/or
      emulator instance.
      
         . build/android/envsetup.sh
         android_gyp -Goutput_dir=out_android_arm
         ninja -C out_android_arm/Release

         . build/android/envsetup.sh --target-arch=x86
         android_gyp -Goutput_dir=out_android_x86
         ninja -C out_android_x86/Release

I don't know about the state of the Linux/MIPS or Android/MIPS builds 
at this point though.

Note however that I tested the OpenSSL MIPS build on Android/MIPS a few
weeks/months ago (i.e. running the full unit tests from the Android's
external/openssl), so I'm quite confident that this should "just" work unless
there is a small bug in the script that generates openssl.gypi included by
openssl.gyp.

[digit1, 2013-04-22 13:28:33]

Actually, forget about it. This change shouldn't change the host and Android
builds (except for Android/MIPS). This means checking the linux_redux build
isn't necessary, _unless_ you can build Chromium on Linux/MIPS.

[petarj, 2013-04-22 13:49:45]

On 2013/04/22 13:28:33, digit1 wrote:
> Actually, forget about it. This change shouldn't change the host and Android
> builds (except for Android/MIPS). This means checking the linux_redux build
> isn't necessary, _unless_ you can build Chromium on Linux/MIPS.

Ok, thanks.
I do not think I have sufficient permission to push the change myself to
this repository. Can you do that for me?

[digit, 2013-04-22 13:57:58]

Yes, we need the approval of one of the owners first though.

[agl, 2013-04-22 14:47:49]

lgtm

[wtc, 2013-04-22 18:31:28]

Patch set 1 LGTM.

Note: in the CL's description, you can just say
  BUG=130022

It's not necessary to provide the URL of the bug report.

[petarj, 2013-04-22 23:14:44]

On 2013/04/22 18:31:28, wtc wrote:
> Patch set 1 LGTM.
> 
> Note: in the CL's description, you can just say
>   BUG=130022
> 
> It's not necessary to provide the URL of the bug report.

Thanks everyone (Adam, Wan-Teh, David) for quick response and review.
Should part of this change be (auto-generated) changes in openssl.gypi as well?

[petarj, 2013-04-23 12:09:04]

On 2013/04/22 23:14:44, petarj wrote:
> On 2013/04/22 18:31:28, wtc wrote:
> > Patch set 1 LGTM.
> > 
> > Note: in the CL's description, you can just say
> >   BUG=130022
> > 
> > It's not necessary to provide the URL of the bug report.
> 
> Thanks everyone (Adam, Wan-Teh, David) for quick response and review.
> Should part of this change be (auto-generated) changes in openssl.gypi as
well?

David, should I upload changes to openssl.gypi too?

[digit, 2013-04-23 12:19:04]

Yes, all changes from running import_from_android.sh should be there. I should
have caught that :(

[petarj, 2013-04-23 12:40:44]

Changes in openssl.gypi added. PTAL.

[wtc, 2013-04-23 17:31:53]

Patch set 2 LGTM.

[petarj, 2013-04-24 14:15:31]

On 2013/04/23 17:31:53, wtc wrote:
> Patch set 2 LGTM.

David, can you push the change? Thanks.

[digit1, 2013-04-29 16:07:34]

Mmm, it seems I can't push the change manually either from checking commit, gcl
dcommit or git cl push (after trying to replicate the patch in my workspace). 

Ryan or Adam, do you know how to handle this?

[digit1, 2013-04-29 16:23:00]

I've duplicated this in https://chromiumcodereview.appspot.com/14531003/ to be
able to submit the latter. Please take a look. Thanks.

[petarj, 2013-04-29 17:34:51]

On 2013/04/29 16:23:00, digit1 wrote:
> I've duplicated this in https://chromiumcodereview.appspot.com/14531003/ to be
> able to submit the latter. Please take a look. Thanks.

Comitted at:
https://chromiumcodereview.appspot.com/14531003/