Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Unified Diff: src/objects.cc

Issue 14371007: Ensure callbacks transitions are actually followed. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 17c648a536011dd9bdd507947ddd1e6eed220a78..dd2d9b68c1826f6a6ed4931e155ac4ea8e89d82f 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -5390,9 +5390,9 @@ MaybeObject* JSObject::DefineFastAccessor(Name* name,
LookupResult result(GetIsolate());
LocalLookup(name, &result);
- if (result.IsFound()
- && !result.IsPropertyCallbacks()
- && !result.IsTransition()) return GetHeap()->null_value();
+ if (result.IsFound() && !result.IsPropertyCallbacks()) {
+ return GetHeap()->null_value();
+ }
// Return success if the same accessor with the same attributes already exist.
AccessorPair* source_accessors = NULL;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698