Issue 14371003: [chromedriver] Enable acceptSslCerts and ignore NULL for proxy.

Issue 14371003: [chromedriver] Enable acceptSslCerts and ignore NULL for proxy. (Closed)

Created:
7 years, 8 months ago by chrisgao (Use stgao instead)

Modified:
7 years, 8 months ago

Reviewers:
kkania

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[chromedriver] Enable acceptSslCerts and ignore NULL for proxy. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196279

Patch Set 2 : Address comments. #

Patch Set 4 : Fix unit test. #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -7 lines)			Patch
M	chrome/test/chromedriver/capabilities.cc	View	1 2 3	2 chunks	+8 lines, -4 lines	0 comments	Download
M	chrome/test/chromedriver/capabilities_unittest.cc	View	1 2 3	2 chunks	+18 lines, -1 line	0 comments	Download
M	chrome/test/chromedriver/chrome_launcher.cc	View	1 2 3	3 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/test/chromedriver/test_expectations	View	1	2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

chrisgao (Use stgao instead)

https://codereview.chromium.org/14371003/diff/2001/chrome/test/chromedriver/capabilities.cc File chrome/test/chromedriver/capabilities.cc (right): https://codereview.chromium.org/14371003/diff/2001/chrome/test/chromedriver/capabilities.cc#newcode237 chrome/test/chromedriver/capabilities.cc:237: command.AppendSwitch("ignore-certificate-errors"); Let us always enable "ignore-certificate-errors" just as the ...

7 years, 8 months ago (2013-04-19 17:11:07 UTC) #1

kkania

lgtm https://codereview.chromium.org/14371003/diff/2001/chrome/test/chromedriver/capabilities.cc File chrome/test/chromedriver/capabilities.cc (right): https://codereview.chromium.org/14371003/diff/2001/chrome/test/chromedriver/capabilities.cc#newcode237 chrome/test/chromedriver/capabilities.cc:237: command.AppendSwitch("ignore-certificate-errors"); On 2013/04/19 17:11:07, chrisgao wrote: > Let ...

7 years, 8 months ago (2013-04-20 01:01:38 UTC) #2

chrisgao (Use stgao instead)

https://codereview.chromium.org/14371003/diff/2001/chrome/test/chromedriver/chrome_launcher.cc File chrome/test/chromedriver/chrome_launcher.cc (right): https://codereview.chromium.org/14371003/diff/2001/chrome/test/chromedriver/chrome_launcher.cc#newcode209 chrome/test/chromedriver/chrome_launcher.cc:209: LOG(INFO) << "Launching chrome: " << command_line_str; On 2013/04/20 ...

7 years, 8 months ago (2013-04-24 17:59:05 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrisgao@chromium.org/14371003/23001

7 years, 8 months ago (2013-04-24 18:00:46 UTC) #4

commit-bot: I haz the power

Retried try job too often on linux_rel for step(s) chromedriver2_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=120341

7 years, 8 months ago (2013-04-24 18:41:30 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrisgao@chromium.org/14371003/38001

7 years, 8 months ago (2013-04-24 22:04:11 UTC) #6

Message was sent while issue was closed.

Change committed as 196279

Expand Messages | Collapse Messages