Issue 14367027: Deflaking the Commands test that makes sure extension commands can't overwrite Chrome shortcuts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14367027: Deflaking the Commands test that makes sure extension commands can't overwrite Chrome shortcuts. (Closed)

Created:
7 years, 8 months ago by Finnur

Modified:
7 years, 8 months ago

Reviewers:
sky

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Deflaking the Commands test that makes sure extension commands can't overwrite Chrome shortcuts. TBR=sky BUG=226994 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195306

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -15 lines)			Patch
	M	chrome/browser/extensions/extension_keybinding_apitest.cc	View		2 chunks	+10 lines, -4 lines	0 comments	Download
	M	chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/background.js	View		1 chunk	+12 lines, -11 lines	0 comments	Download

Total messages: 2 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/finnur@chromium.org/14367027/1

7 years, 8 months ago (2013-04-19 19:18:51 UTC) #1

Message was sent while issue was closed.

Change committed as 195306