Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1199)

Issue 14366023: [Android] Only set recommended flags if they are unset (Closed)

Created:
7 years, 8 months ago by cjhopman
Modified:
7 years, 8 months ago
Reviewers:
Yaron
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, ilevy+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

[Android] Only set recommended flags if they are unset This allows developers to force the values of individual flags in their chrome/supplement.gypi. Add documentation for how a user can do that. Also add a comment about the fastbuild option, but do not ever set it by default. NOTRY=true BUG=158821 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195334

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Patch
M build/android/developer_recommended_flags.gypi View 1 2 chunks +21 lines, -6 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
cjhopman
7 years, 8 months ago (2013-04-19 18:31:58 UTC) #1
Yaron
https://codereview.chromium.org/14366023/diff/2001/build/android/developer_recommended_flags.gypi File build/android/developer_recommended_flags.gypi (right): https://codereview.chromium.org/14366023/diff/2001/build/android/developer_recommended_flags.gypi#newcode7 build/android/developer_recommended_flags.gypi:7: # These can be used by copying this file ...
7 years, 8 months ago (2013-04-19 22:44:27 UTC) #2
cjhopman
https://codereview.chromium.org/14366023/diff/2001/build/android/developer_recommended_flags.gypi File build/android/developer_recommended_flags.gypi (right): https://codereview.chromium.org/14366023/diff/2001/build/android/developer_recommended_flags.gypi#newcode7 build/android/developer_recommended_flags.gypi:7: # These can be used by copying this file ...
7 years, 8 months ago (2013-04-19 22:51:18 UTC) #3
Yaron
lgtm Cool! Didn't know
7 years, 8 months ago (2013-04-19 23:26:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/14366023/2001
7 years, 8 months ago (2013-04-19 23:26:57 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 23:27:08 UTC) #6
Message was sent while issue was closed.
Change committed as 195334

Powered by Google App Engine
This is Rietveld 408576698