Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issue 14365017: Propagate OOM exception instead of crashing in CALL_HEAP_FUNCTION_PASS_EXCEPTION macro. (Closed)

Created:
7 years, 8 months ago by ulan
Modified:
7 years, 8 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Propagate OOM exception instead of crashing in CALL_HEAP_FUNCTION_PASS_EXCEPTION macro. R=jkummerow@chromium.org BUG=webkit/fast/js/concat-large-strings-crash.html Committed: https://code.google.com/p/v8/source/detail?r=14358

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -43 lines) Patch
M src/heap-inl.h View 1 chunk +50 lines, -39 lines 0 comments Download
M src/objects.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
PTAL
7 years, 8 months ago (2013-04-19 15:46:20 UTC) #1
Jakob Kummerow
lgtm
7 years, 8 months ago (2013-04-19 15:53:51 UTC) #2
ulan
7 years, 8 months ago (2013-04-19 15:55:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14358 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698