Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 14365009: Feed Clang a pragma to ignore -Wc++11-extensions to let it build Skia on Mac. (Closed)

Created:
7 years, 8 months ago by mtklein
Modified:
7 years, 8 months ago
Reviewers:
bungeman-skia
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Feed Clang a pragma to ignore -Wc++11-extensions to let it build Skia on Mac. Tested: CXX=clang++ ./gyp_skia && ninja -C out/Debug && CXX=G++ ./gyp_skia && ninja -C out/Debug && echo "ok" Got to ok. BUG= Committed: http://code.google.com/p/skia/source/detail?r=8799

Patch Set 1 #

Patch Set 2 : sigh, now both Clang and GCC work #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M include/core/SkPostConfig.h View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mtklein
Clang turned out to be easy!
7 years, 8 months ago (2013-04-19 03:23:02 UTC) #1
mtklein
Had to change the approach a little. Apple's GCC doesn't know -Wno-c++11-extensions.
7 years, 8 months ago (2013-04-19 03:49:16 UTC) #2
bungeman-skia
I don't like it, but I can't find a more acceptable means of doing this. ...
7 years, 8 months ago (2013-04-19 15:20:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/14365009/3001
7 years, 8 months ago (2013-04-19 15:44:34 UTC) #4
rmistry
On 2013/04/19 15:44:34, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
7 years, 8 months ago (2013-04-22 12:34:10 UTC) #5
commit-bot: I haz the power
Change committed as 8799
7 years, 8 months ago (2013-04-22 14:39:07 UTC) #6
mtklein
7 years, 8 months ago (2013-04-22 14:41:11 UTC) #7
Message was sent while issue was closed.
On 2013/04/22 12:34:10, rmistry wrote:
> On 2013/04/19 15:44:34, I haz the power (commit-bot) wrote:
> > CQ is trying da patch. Follow status at
> > https://skia-tree-status.appspot.com/cq/mtklein%2540google.com/14365009/3001
> 
> CQ was stuck because some bots were offline due to a tripped breaker. They
> should be coming up shortly now.

Ah, was wondering.  Thanks!

Powered by Google App Engine
This is Rietveld 408576698