Issue 14361004: Lower kLowBatteryLevel from 15 to 5

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14361004: Lower kLowBatteryLevel from 15 to 5 (Closed)

Created:
7 years, 8 months ago by Yufeng Shen (Slow to review)

Modified:
7 years, 8 months ago

Reviewers:
Daniel Erat

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, derat+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Lower kLowBatteryLevel from 15 to 5 I just realized that an external battery-backed input device with battery level around 15% can actually last a very long time (like one week ?). So change kLowBatteryLevel to 5% seems making more sense for "Low" battery notification. BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195165

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/chromeos/power/peripheral_battery_observer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miletus@chromium.org/14361004/1

7 years, 8 months ago (2013-04-18 19:19:04 UTC) #3

commit-bot: I haz the power

Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=30327

7 years, 8 months ago (2013-04-18 23:05:02 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miletus@chromium.org/14361004/1

7 years, 8 months ago (2013-04-19 03:24:26 UTC) #5

Message was sent while issue was closed.

Change committed as 195165

Expand Messages | Collapse Messages