Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 14359005: Remove unnecessary files from unit_tests and browser_tests in windows/isolate. (Closed)

Created:
7 years, 8 months ago by M-A Ruel
Modified:
7 years, 8 months ago
Reviewers:
csharp
CC:
chromium-reviews, Vadim Sh.
Visibility:
Public.

Description

Remove unnecessary files from unit_tests and browser_tests in windows/isolate. The trace_inputs.py implementation on Windows is a bit fuzzy and occasionally includes files that were not accessed. The Builder/Testers setup on the CI caught these. NOTRY=true TBR=csharp@chromium.org BUG=98636 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195786

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/browser_tests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/unit_tests.isolate View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
7 years, 8 months ago (2013-04-23 13:40:10 UTC) #1
M-A Ruel
TBR'ing, this is blocking the runisolated rollout.
7 years, 8 months ago (2013-04-23 13:46:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/14359005/1
7 years, 8 months ago (2013-04-23 13:46:47 UTC) #3
commit-bot: I haz the power
Change committed as 195786
7 years, 8 months ago (2013-04-23 13:46:55 UTC) #4
csharp
7 years, 8 months ago (2013-04-23 15:00:36 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698