Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 14358019: Added Cloud Print Service installer/uninstaller. (Closed)

Created:
7 years, 8 months ago by Vitaly Buka (NO REVIEWS)
Modified:
7 years, 8 months ago
Reviewers:
gene
CC:
chromium-reviews
Visibility:
Public.

Description

Added Cloud Print Service installer/uninstaller. Added Google Update integration. R=gene BUG=229183 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195765

Patch Set 1 : #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -18 lines) Patch
M cloud_print/service/service.gyp View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
A cloud_print/service/service_constants.h View 1 chunk +13 lines, -0 lines 0 comments Download
A cloud_print/service/service_constants.cc View 1 chunk +10 lines, -0 lines 0 comments Download
D cloud_print/service/service_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
D cloud_print/service/service_switches.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M cloud_print/service/win/chrome_launcher.cc View 1 4 chunks +10 lines, -4 lines 0 comments Download
M cloud_print/service/win/cloud_print_service.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M cloud_print/service/win/cloud_print_service_config.cc View 1 3 chunks +6 lines, -2 lines 0 comments Download
A cloud_print/service/win/installer.h View 1 1 chunk +15 lines, -0 lines 0 comments Download
A cloud_print/service/win/installer.cc View 1 chunk +125 lines, -0 lines 0 comments Download
M cloud_print/service/win/service_controller.h View 3 chunks +7 lines, -1 line 0 comments Download
M cloud_print/service/win/service_controller.cc View 6 chunks +54 lines, -8 lines 0 comments Download
M cloud_print/service/win/service_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Vitaly Buka (NO REVIEWS)
7 years, 8 months ago (2013-04-23 00:07:34 UTC) #1
gene
lgtm, a few nits below https://chromiumcodereview.appspot.com/14358019/diff/22/cloud_print/service/service_switches.cc File cloud_print/service/service_switches.cc (right): https://chromiumcodereview.appspot.com/14358019/diff/22/cloud_print/service/service_switches.cc#newcode14 cloud_print/service/service_switches.cc:14: const char kUninstallSwitch[] = ...
7 years, 8 months ago (2013-04-23 01:13:59 UTC) #2
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/14358019/diff/22/cloud_print/service/service_switches.cc File cloud_print/service/service_switches.cc (right): https://codereview.chromium.org/14358019/diff/22/cloud_print/service/service_switches.cc#newcode14 cloud_print/service/service_switches.cc:14: const char kUninstallSwitch[] = "uninstall"; On 2013/04/23 01:13:59, gene ...
7 years, 8 months ago (2013-04-23 04:58:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/14358019/20001
7 years, 8 months ago (2013-04-23 04:59:03 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-23 05:28:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/14358019/36001
7 years, 8 months ago (2013-04-23 06:00:51 UTC) #6
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-23 07:18:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/14358019/36001
7 years, 8 months ago (2013-04-23 08:06:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/14358019/36001
7 years, 8 months ago (2013-04-23 08:27:13 UTC) #9
commit-bot: I haz the power
7 years, 8 months ago (2013-04-23 08:27:45 UTC) #10
Message was sent while issue was closed.
Change committed as 195765

Powered by Google App Engine
This is Rietveld 408576698