Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 14358006: Eliminating recordEvent call with string parameter (Closed)

Created:
7 years, 8 months ago by vadimt
Modified:
7 years, 8 months ago
CC:
chromium-reviews, arv+watch_chromium.org, stromme, govind1
Visibility:
Public.

Description

Eliminating recordEvent call with string parameter. This was a merge error. BUG=164227 TEST=No Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195039

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/resources/google_now/background.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
vadimt
7 years, 8 months ago (2013-04-18 19:29:40 UTC) #1
skare_
lgtm
7 years, 8 months ago (2013-04-18 19:38:35 UTC) #2
rgustafson
lgtm
7 years, 8 months ago (2013-04-18 19:43:38 UTC) #3
vadimt
arv@, please provide OWNER's approval
7 years, 8 months ago (2013-04-18 19:45:33 UTC) #4
arv (Not doing code reviews)
7 years, 8 months ago (2013-04-18 21:54:30 UTC) #5
arv (Not doing code reviews)
LGTM
7 years, 8 months ago (2013-04-18 21:54:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vadimt@chromium.org/14358006/1
7 years, 8 months ago (2013-04-18 22:01:46 UTC) #7
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 01:09:08 UTC) #8
Message was sent while issue was closed.
Change committed as 195039

Powered by Google App Engine
This is Rietveld 408576698