Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1701)

Unified Diff: chrome/browser/extensions/api/web_request/web_request_permissions.h

Issue 14358004: Almost all actions in Declarative Web Request require all_urls host permissions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: All URLs -> all hosts; also rebased Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/web_request/web_request_permissions.h
diff --git a/chrome/browser/extensions/api/web_request/web_request_permissions.h b/chrome/browser/extensions/api/web_request/web_request_permissions.h
index 1d1297c2455f587bdd7abd38bc0a0b3323eac808..6ff0f431f765a5580a19c4b888a52387779ea2b1 100644
--- a/chrome/browser/extensions/api/web_request/web_request_permissions.h
+++ b/chrome/browser/extensions/api/web_request/web_request_permissions.h
@@ -20,15 +20,25 @@ class URLRequest;
// This class is used to test whether extensions may modify web requests.
class WebRequestPermissions {
public:
+ // Different host permission checking modes for CanExtensionAccessURL.
+ enum HostPermissionsCheck {
+ DO_NOT_CHECK_HOST = 0, // No check.
+ REQUIRE_HOST_PERMISSION, // Permission needed for given URL.
+ REQUIRE_ALL_URLS // Permission needed for <all_urls>.
+ };
+
// Returns true if the request shall not be reported to extensions.
static bool HideRequest(const ExtensionInfoMap* extension_info_map,
const net::URLRequest* request);
- static bool CanExtensionAccessURL(const ExtensionInfoMap* extension_info_map,
- const std::string& extension_id,
- const GURL& url,
- bool crosses_incognito,
- bool enforce_host_permissions);
+ // |host_permission_check| controls how permissions are checked with regard to
+ // |url|.
+ static bool CanExtensionAccessURL(
+ const ExtensionInfoMap* extension_info_map,
+ const std::string& extension_id,
+ const GURL& url,
+ bool crosses_incognito,
+ HostPermissionsCheck host_permissions_check);
private:
DISALLOW_IMPLICIT_CONSTRUCTORS(WebRequestPermissions);

Powered by Google App Engine
This is Rietveld 408576698