chrome/browser/extensions/api/web_request/web_request_apitest.cc - Issue 14358004: Almost all actions in Declarative Web Request require all_urls host permissions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/web_request_apitest.cc

Issue 14358004: Almost all actions in Declarative Web Request require all_urls host permissions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: All URLs -> all hosts; also rebased Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_request/web_request_api.cc ('k') | chrome/browser/extensions/api/web_request/web_request_permissions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/web_request_apitest.cc

diff --git a/chrome/browser/extensions/api/web_request/web_request_apitest.cc b/chrome/browser/extensions/api/web_request/web_request_apitest.cc

index 2f53bb582c77c81054e1b1fc17fb5c24c08384f0..200e12d83c730b0cfc423a50275cb7061a7b1331 100644

--- a/chrome/browser/extensions/api/web_request/web_request_apitest.cc

+++ b/chrome/browser/extensions/api/web_request/web_request_apitest.cc

@@ -159,17 +159,6 @@ IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest,

<< message_;

}

-IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest,

- WebRequestDeclarativePermissions) {

- ExtensionTestMessageListener listener("rules all registered", false);

- ASSERT_TRUE(LoadExtension(test_data_dir_.AppendASCII(

- "webrequest/permissionless")));

- EXPECT_TRUE(listener.WaitUntilSatisfied());

- ASSERT_TRUE(RunExtensionSubtest(

- "webrequest", "test_declarative_permissions.html")) <<

- message_;

void ExtensionWebRequestApiTest::RunPermissionTest(

const char* extension_directory,

bool load_extension_with_incognito_permission,