chrome/browser/extensions/api/declarative_content/content_rules_registry.cc - Issue 14358004: Almost all actions in Declarative Web Request require all_urls host permissions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_content/content_rules_registry.cc

Issue 14358004: Almost all actions in Declarative Web Request require all_urls host permissions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: All URLs -> all hosts; also rebased Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative/declarative_rule_unittest.cc ('k') | chrome/browser/extensions/api/declarative_webrequest/webrequest_action.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_content/content_rules_registry.cc

diff --git a/chrome/browser/extensions/api/declarative_content/content_rules_registry.cc b/chrome/browser/extensions/api/declarative_content/content_rules_registry.cc

index eb95b475359169e149dff637d12e99e1086571b6..95896331eb4a351313d0b6b95d443bdc337104f6 100644

--- a/chrome/browser/extensions/api/declarative_content/content_rules_registry.cc

+++ b/chrome/browser/extensions/api/declarative_content/content_rules_registry.cc

@@ -139,8 +139,12 @@ std::string ContentRulesRegistry::AddRulesImpl(

DCHECK(content_rules_.find(rule_id) == content_rules_.end());

scoped_ptr<ContentRule> content_rule(

- ContentRule::Create(url_matcher_.condition_factory(), extension_id,

- extension_installation_time, *rule, NULL, &error));

+ ContentRule::Create(url_matcher_.condition_factory(),

+ extension_id,

+ extension_installation_time,

+ *rule,

+ ContentRule::ConsistencyChecker(),

+ &error));

if (!error.empty()) {

// Clean up temporary condition sets created during rule creation.

url_matcher_.ClearUnusedConditionSets();