Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 14354006: Reset the OAuth2LoginManager fetchers when restoring a new session. (Closed)

Created:
7 years, 8 months ago by Joao da Silva
Modified:
7 years, 8 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Reset the OAuth2LoginManager fetchers when restoring a new session. This avoids DHECKing when a previous session has already been restored, when using multi-profiles. OAuth2LoginManager should handle the session restore state for multiple profiles once multi-profile support is added. BUG=230342 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195239

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/chromeos/login/oauth2_login_manager.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Joao da Silva
7 years, 8 months ago (2013-04-18 14:35:15 UTC) #1
Nikita (slow)
lgtm
7 years, 8 months ago (2013-04-18 17:21:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/14354006/1
7 years, 8 months ago (2013-04-18 17:22:12 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-18 18:01:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/14354006/1
7 years, 8 months ago (2013-04-18 19:45:49 UTC) #5
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=30391
7 years, 8 months ago (2013-04-19 00:54:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/14354006/1
7 years, 8 months ago (2013-04-19 07:01:21 UTC) #7
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 18:25:45 UTC) #8
Message was sent while issue was closed.
Change committed as 195239

Powered by Google App Engine
This is Rietveld 408576698