Fix HTTPCacheTransaction conditionalization header check.

Fix HTTPCacheTransaction conditionalization header check.

This fixes a minor bug that went undetected because the HTTPCache unit tests
used \n as the line terminator instead of \r\n.

+ Fix the unit tests to consistently use \r\n as a line terminator
  instead of \n.

+ Remove broken ConditionalizedRequestUpdatesCache11 unit test, per
  Ricardo's suggestion.

For more details, see the bug entry.

BUG=231884
R=rvargas@chromium.org,mmenke@chromium.org,eroman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195699

[gavinp, 2013-04-18 13:29:26]

-eromann
+eroman

[digit1, 2013-04-18 14:25:55]

Wow, these failures are unexpected. I'm looking at them

[digit1, 2013-04-22 09:42:48]

The failures came from calling HttpRequestHeaders::AddHeaderFromString() with a
\r\n line terminator, while the function expects a line without any line
terminator. I don't understand why I couldn't reproduce this locally though (I
tested the linux, linux_redux and android builds of net_unittests).

[eroman, 2013-04-22 20:07:05]

Thanks, I'll defer this review to rvargas.

[mmenke, 2013-04-22 20:11:30]

On 2013/04/22 20:07:05, eroman wrote:
> Thanks, I'll defer this review to rvargas.

Likewise, I really don't know the cache code.

[rvargas (doing something else), 2013-04-22 21:28:31]

LGTM. Thanks.

[commit-bot: I haz the power, 2013-04-22 22:38:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/digit@chromium.org/14352006/7001

[commit-bot: I haz the power, 2013-04-23 03:06:31]

Change committed as 195699