Made the ChromotingHost class not ref-counted.

Made the ChromotingHost class not ref-counted.

ChromotingHost becomes a non thread-safe class should should live on the network thread. The CL removes ChromotingHost::Shutdown() allowing ChromotingHost to be destroyed synchronously closing all existing connection.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197458

[alexeypa (please no reviews), 2013-04-26 00:02:55]

https://chromiumcodereview.appspot.com/13466014/ broke it2me shoutdown. This is
a fixed version.

Patch #1 is the original CL.
Patch #2 is the fix.

PTAL.

[alexeypa (please no reviews), 2013-04-30 16:52:05]

Wez, since you looked at other CLs today, how about this one? Ping.

[Wez, 2013-04-30 17:28:32]

On 2013/04/30 16:52:05, alexeypa wrote:
> Wez, since you looked at other CLs today, how about this one? Ping.

nit: I see a lot of red try-bots... ;)

[alexeypa (please no reviews), 2013-04-30 18:05:57]

On 2013/04/30 17:28:32, Wez wrote:
> On 2013/04/30 16:52:05, alexeypa wrote:
> > Wez, since you looked at other CLs today, how about this one? Ping.
> 
> nit: I see a lot of red try-bots... ;)

I noticed. They all are update failures. I'll rebase and try again. Could you
take a look at the CL in the meantime?

[Sergey Ulanov, 2013-04-30 18:26:46]

LGTM, but see my nits.

https://chromiumcodereview.appspot.com/14348042/diff/2001/remoting/host/chrom...
File remoting/host/chromoting_host.cc (right):

https://chromiumcodereview.appspot.com/14348042/diff/2001/remoting/host/chrom...
remoting/host/chromoting_host.cc:107: if (started_) {
nit: remove {}

https://chromiumcodereview.appspot.com/14348042/diff/2001/remoting/host/plugi...
File remoting/host/plugin/host_script_object.cc (right):

https://chromiumcodereview.appspot.com/14348042/diff/2001/remoting/host/plugi...
remoting/host/plugin/host_script_object.cc:274: SetState(kDisconnecting);
nit: we don't need disconnecting state anymore because we always go from
disconnecting state to disconnected synchronously, so this code can be
simplified further. Feel free to keep it for now, but maybe add TODO for it.

https://chromiumcodereview.appspot.com/14348042/diff/2001/remoting/host/plugi...
remoting/host/plugin/host_script_object.cc:415:
host_->RemoveStatusObserver(this);
Don't need this anymore, I think.

[alexeypa (please no reviews), 2013-04-30 18:39:56]

https://chromiumcodereview.appspot.com/14348042/diff/2001/remoting/host/chrom...
File remoting/host/chromoting_host.cc (right):

https://chromiumcodereview.appspot.com/14348042/diff/2001/remoting/host/chrom...
remoting/host/chromoting_host.cc:107: if (started_) {
On 2013/04/30 18:26:46, Sergey Ulanov wrote:
> nit: remove {}

Done.

https://chromiumcodereview.appspot.com/14348042/diff/2001/remoting/host/plugi...
File remoting/host/plugin/host_script_object.cc (right):

https://chromiumcodereview.appspot.com/14348042/diff/2001/remoting/host/plugi...
remoting/host/plugin/host_script_object.cc:274: SetState(kDisconnecting);
On 2013/04/30 18:26:46, Sergey Ulanov wrote:
> nit: we don't need disconnecting state anymore because we always go from
> disconnecting state to disconnected synchronously, so this code can be
> simplified further. Feel free to keep it for now, but maybe add TODO for it.

The disconnecting state is still needed because we post
It2MeImpl::ShutdownOnNetworkThread() to the network thread at line 286.

https://chromiumcodereview.appspot.com/14348042/diff/2001/remoting/host/plugi...
remoting/host/plugin/host_script_object.cc:415:
host_->RemoveStatusObserver(this);
On 2013/04/30 18:26:46, Sergey Ulanov wrote:
> Don't need this anymore, I think.

ObserverList<>::~ObserverList DCHECKs that all observers were unregistered.

[commit-bot: I haz the power, 2013-04-30 18:40:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/14348042/18001

[Sergey Ulanov, 2013-04-30 18:55:19]

https://chromiumcodereview.appspot.com/14348042/diff/2001/remoting/host/plugi...
File remoting/host/plugin/host_script_object.cc (right):

https://chromiumcodereview.appspot.com/14348042/diff/2001/remoting/host/plugi...
remoting/host/plugin/host_script_object.cc:274: SetState(kDisconnecting);
On 2013/04/30 18:39:56, alexeypa wrote:
> On 2013/04/30 18:26:46, Sergey Ulanov wrote:
> > nit: we don't need disconnecting state anymore because we always go from
> > disconnecting state to disconnected synchronously, so this code can be
> > simplified further. Feel free to keep it for now, but maybe add TODO for it.
> 
> The disconnecting state is still needed because we post
> It2MeImpl::ShutdownOnNetworkThread() to the network thread at line 286. 
> 

Right, but potentially we could just always post a new task for Disconnect(),
and in that case we wouldn't need to post task in line 286.

[Wez, 2013-04-30 19:04:45]

Yes, will do
On 30 Apr 2013 19:05, <alexeypa@chromium.org> wrote:

> On 2013/04/30 17:28:32, Wez wrote:
>
>> On 2013/04/30 16:52:05, alexeypa wrote:
>> > Wez, since you looked at other CLs today, how about this one? Ping.
>>
>
>  nit: I see a lot of red try-bots... ;)
>>
>
> I noticed. They all are update failures. I'll rebase and try again. Could
> you
> take a look at the CL in the meantime?
>
>
https://chromiumcodereview.**appspot.com/14348042/<https://chromiumcodereview...
>

[commit-bot: I haz the power, 2013-04-30 20:46:17]

Change committed as 197458