Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: components/autofill/browser/webdata/autofill_webdata_service.h

Issue 14348036: Move AutofillWebData DB methods into separate class (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Pure merge Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/browser/webdata/autofill_webdata_service.h
diff --git a/components/autofill/browser/webdata/autofill_webdata_service.h b/components/autofill/browser/webdata/autofill_webdata_service.h
index bfa9d5843abdf22e6f3dc8efc71ce309e5f5003a..87b967ca94bb2283270198968fe60b21399cfbf4 100644
--- a/components/autofill/browser/webdata/autofill_webdata_service.h
+++ b/components/autofill/browser/webdata/autofill_webdata_service.h
@@ -27,6 +27,7 @@ namespace autofill {
class AutofillChange;
class AutofillProfile;
+class AutofillWebDataBackend;
class AutofillWebDataServiceObserverOnDBThread;
class AutofillWebDataServiceObserverOnUIThread;
class CreditCard;
@@ -101,42 +102,6 @@ class AutofillWebDataService : public AutofillWebData,
virtual void ShutdownOnDBThread();
private:
- WebDatabase::State AddFormElementsImpl(
- const std::vector<FormFieldData>& fields, WebDatabase* db);
- scoped_ptr<WDTypedResult> GetFormValuesForElementNameImpl(
- const base::string16& name, const base::string16& prefix, int limit,
- WebDatabase* db);
- WebDatabase::State RemoveFormElementsAddedBetweenImpl(
- const base::Time& delete_begin, const base::Time& delete_end,
- WebDatabase* db);
- WebDatabase::State RemoveExpiredFormElementsImpl(WebDatabase* db);
- WebDatabase::State RemoveFormValueForElementNameImpl(
- const base::string16& name, const base::string16& value, WebDatabase* db);
- WebDatabase::State AddAutofillProfileImpl(
- const AutofillProfile& profile, WebDatabase* db);
- WebDatabase::State UpdateAutofillProfileImpl(
- const AutofillProfile& profile, WebDatabase* db);
- WebDatabase::State RemoveAutofillProfileImpl(
- const std::string& guid, WebDatabase* db);
- scoped_ptr<WDTypedResult> GetAutofillProfilesImpl(WebDatabase* db);
- WebDatabase::State AddCreditCardImpl(
- const CreditCard& credit_card, WebDatabase* db);
- WebDatabase::State UpdateCreditCardImpl(
- const CreditCard& credit_card, WebDatabase* db);
- WebDatabase::State RemoveCreditCardImpl(
- const std::string& guid, WebDatabase* db);
- scoped_ptr<WDTypedResult> GetCreditCardsImpl(WebDatabase* db);
- WebDatabase::State RemoveAutofillDataModifiedBetweenImpl(
- const base::Time& delete_begin, const base::Time& delete_end,
- WebDatabase* db);
-
- // Callbacks to ensure that sensitive info is destroyed if request is
- // cancelled.
- void DestroyAutofillProfileResult(const WDTypedResult* result);
- void DestroyAutofillCreditCardResult(const WDTypedResult* result);
-
- void NotifyAutofillMultipleChangedOnUIThread();
-
// This makes the destructor public, and thus allows us to aggregate
// SupportsUserData. It is private by default to prevent incorrect
// usage in class hierarchies where it is inherited by
@@ -149,14 +114,17 @@ class AutofillWebDataService : public AutofillWebData,
DISALLOW_COPY_AND_ASSIGN(SupportsUserDataAggregatable);
};
+ void NotifyAutofillMultipleChangedOnUIThread();
+
// Storage for user data to be accessed only on the DB thread. May
// be used e.g. for SyncableService subclasses that need to be owned
// by this object. Is created on first call to |GetDBUserData()|.
scoped_ptr<SupportsUserDataAggregatable> db_thread_user_data_;
- ObserverList<AutofillWebDataServiceObserverOnDBThread> db_observer_list_;
ObserverList<AutofillWebDataServiceObserverOnUIThread> ui_observer_list_;
+ scoped_refptr<AutofillWebDataBackend> autofill_backend_;
+
DISALLOW_COPY_AND_ASSIGN(AutofillWebDataService);
};

Powered by Google App Engine
This is Rietveld 408576698