Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14348016: chromeos: Add DriveFileSystem::Pin/Unpin (Closed)

Created:
7 years, 8 months ago by hashimoto
Modified:
7 years, 8 months ago
Reviewers:
hidehiko, kinaba
CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

chromeos: Add DriveFileSystem::Pin/Unpin BUG=232450 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195235

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use GetEntryInfoByPathSync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -6 lines) Patch
M chrome/browser/chromeos/drive/drive_file_system.h View 2 chunks +14 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_file_system.cc View 1 chunk +64 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_file_system_interface.h View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_file_system_unittest.cc View 1 1 chunk +30 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/fake_drive_file_system.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/fake_drive_file_system.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/mock_drive_file_system.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hashimoto
7 years, 8 months ago (2013-04-19 07:45:50 UTC) #1
hidehiko
lgtm
7 years, 8 months ago (2013-04-19 08:41:23 UTC) #2
hidehiko
FYI: https://codereview.chromium.org/14348016/diff/1/chrome/browser/chromeos/drive/drive_file_system_unittest.cc File chrome/browser/chromeos/drive/drive_file_system_unittest.cc (right): https://codereview.chromium.org/14348016/diff/1/chrome/browser/chromeos/drive/drive_file_system_unittest.cc#newcode1541 chrome/browser/chromeos/drive/drive_file_system_unittest.cc:1541: scoped_ptr<DriveEntryProto> entry; nit: GetEntryInfoByPathSync should work here?
7 years, 8 months ago (2013-04-19 08:56:28 UTC) #3
kinaba
lgtm
7 years, 8 months ago (2013-04-19 09:57:17 UTC) #4
hashimoto
https://codereview.chromium.org/14348016/diff/1/chrome/browser/chromeos/drive/drive_file_system_unittest.cc File chrome/browser/chromeos/drive/drive_file_system_unittest.cc (right): https://codereview.chromium.org/14348016/diff/1/chrome/browser/chromeos/drive/drive_file_system_unittest.cc#newcode1541 chrome/browser/chromeos/drive/drive_file_system_unittest.cc:1541: scoped_ptr<DriveEntryProto> entry; On 2013/04/19 08:56:28, hidehiko wrote: > nit: ...
7 years, 8 months ago (2013-04-19 10:34:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/14348016/7001
7 years, 8 months ago (2013-04-19 10:34:57 UTC) #6
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 18:05:19 UTC) #7
Message was sent while issue was closed. 
Change committed as 195235

Powered by Google App Engine
This is Rietveld 408576698