Remove legacy in DriveSyncClient.

Remove legacy in DriveSyncClient.

The feature using Profile or Preferences has been moved to DriveScheduler,
so we don't need them here anymore.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195234

[hashimoto, 2013-04-19 03:43:21]

looks good, some minor comments

https://codereview.chromium.org/14348013/diff/1/chrome/browser/chromeos/drive...
File chrome/browser/chromeos/drive/drive_sync_client.h (right):

https://codereview.chromium.org/14348013/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/drive_sync_client.h:14: #include
"chrome/browser/chromeos/drive/drive_cache.h"
Can't this include be replaced with forward declaration?

https://codereview.chromium.org/14348013/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/drive_sync_client.h:37: class DriveSyncClient
Can't this be one line?

https://codereview.chromium.org/14348013/diff/1/chrome/browser/chromeos/drive...
File chrome/browser/chromeos/drive/drive_sync_client_unittest.cc (right):

https://codereview.chromium.org/14348013/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/drive_sync_client_unittest.cc:7: #include
<algorithm>
Is this include needed?

https://codereview.chromium.org/14348013/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/drive_sync_client_unittest.cc:16: #include
"base/path_service.h"
ditto.

https://codereview.chromium.org/14348013/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/drive_sync_client_unittest.cc:17: #include
"base/prefs/pref_service.h"
ditto.

https://codereview.chromium.org/14348013/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/drive_sync_client_unittest.cc:25: #include
"chrome/common/chrome_paths.h"
ditto.

https://codereview.chromium.org/14348013/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/drive_sync_client_unittest.cc:26: #include
"chrome/common/pref_names.h"
ditto.

[kinaba, 2013-04-19 03:51:44]

https://codereview.chromium.org/14348013/diff/1/chrome/browser/chromeos/drive...
File chrome/browser/chromeos/drive/drive_sync_client.h (right):

https://codereview.chromium.org/14348013/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/drive_sync_client.h:14: #include
"chrome/browser/chromeos/drive/drive_cache.h"
On 2013/04/19 03:43:22, hashimoto wrote:
> Can't this include be replaced with forward declaration?

Done.

https://codereview.chromium.org/14348013/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/drive_sync_client.h:37: class DriveSyncClient
On 2013/04/19 03:43:22, hashimoto wrote:
> Can't this be one line?

Done.

https://codereview.chromium.org/14348013/diff/1/chrome/browser/chromeos/drive...
File chrome/browser/chromeos/drive/drive_sync_client_unittest.cc (right):

https://codereview.chromium.org/14348013/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/drive_sync_client_unittest.cc:7: #include
<algorithm>
On 2013/04/19 03:43:22, hashimoto wrote:
> Is this include needed?

Done.

https://codereview.chromium.org/14348013/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/drive_sync_client_unittest.cc:16: #include
"base/path_service.h"
On 2013/04/19 03:43:22, hashimoto wrote:
> ditto.

Done.

https://codereview.chromium.org/14348013/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/drive_sync_client_unittest.cc:17: #include
"base/prefs/pref_service.h"
On 2013/04/19 03:43:22, hashimoto wrote:
> ditto.

Done.

https://codereview.chromium.org/14348013/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/drive_sync_client_unittest.cc:25: #include
"chrome/common/chrome_paths.h"
On 2013/04/19 03:43:22, hashimoto wrote:
> ditto.

Done.

https://codereview.chromium.org/14348013/diff/1/chrome/browser/chromeos/drive...
chrome/browser/chromeos/drive/drive_sync_client_unittest.cc:26: #include
"chrome/common/pref_names.h"
On 2013/04/19 03:43:22, hashimoto wrote:
> ditto.

Done.

[hashimoto, 2013-04-19 03:59:06]

lgtm

https://codereview.chromium.org/14348013/diff/8001/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/drive_sync_client.h (right):

https://codereview.chromium.org/14348013/diff/8001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/drive_sync_client.h:47: // |file_system| is used
access the
nit: This comment is quite wrong. (what is used to access the cache is |cache|.)
I think we can drop this kind of comment when we don't want to note something
special.

[kinaba, 2013-04-19 04:10:16]

Done.
Besides, I found one more thing that is not necessary.
Now Initialize() is a simple job that can be moved to the
constructor (since network or preference monitoring is removed).

https://codereview.chromium.org/14348013/diff/8001/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/drive_sync_client.h (right):

https://codereview.chromium.org/14348013/diff/8001/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/drive_sync_client.h:47: // |file_system| is used
access the
On 2013/04/19 03:59:06, hashimoto wrote:
> nit: This comment is quite wrong. (what is used to access the cache is
|cache|.)
> I think we can drop this kind of comment when we don't want to note something
> special.

Done.

[hashimoto, 2013-04-19 04:12:09]

lgtm

[commit-bot: I haz the power, 2013-04-19 04:14:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/14348013/11002

[commit-bot: I haz the power, 2013-04-19 04:23:59]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-04-19 04:44:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/14348013/11002

[commit-bot: I haz the power, 2013-04-19 18:05:05]

Change committed as 195234